44ccfacbe3a3d4b300f80d48651c77837a4b571e
galt
  Tue Apr 26 11:12:02 2022 -0700
SQL INJECTION Prevention Version 2 - this improves our methods by making subclauses of SQL that get passed around be both easy and correct to use. The way that was achieved was by getting rid of the obscure and not well used functions sqlSafefFrag and sqlDyStringPrintfFrag and replacing them with the plain versions of those functions, since these are not needed anymore. The new version checks for NOSQLINJ in unquoted %-s which is used to include SQL clauses, and will give an error the NOSQLINJ clause is not present, and this will automatically require the correct behavior by developers. sqlDyStringPrint is a very useful function, however because it was not enforced, users could use various other dyString functions and they operated without any awareness or checking for SQL correct use. Now those dyString functions are prohibited and it will produce an error if you try to use a dyString function on a SQL string, which is simply detected by the presence of the NOSQLINJ prefix.

diff --git src/hg/lib/findKGAlias.c src/hg/lib/findKGAlias.c
index bbc4e69..9366f94 100644
--- src/hg/lib/findKGAlias.c
+++ src/hg/lib/findKGAlias.c
@@ -1,59 +1,59 @@
 /* Copyright (C) 2014 The Regents of the University of California 
  * See kent/LICENSE or http://genome.ucsc.edu/license/ for licensing information. */
 
 #include "common.h"
 #include "hCommon.h"
 #include "hdb.h"
 #include "errAbort.h"
 #include "kgAlias.h"
 
 static void addKgAlias(struct sqlConnection *conn, struct dyString *query,
        struct kgAlias **pList)
 /* Query database and add returned kgAlias to head of list. */
 {
 struct sqlResult *sr = sqlGetResult(conn, query->string);
 char **row;
 while ((row = sqlNextRow(sr)) != NULL)
     {
     struct kgAlias *kl = kgAliasLoad(row);
     slAddHead(pList, kl);
     }
 sqlFreeResult(&sr);
 }
 
 struct kgAlias *findKGAlias(char *dataBase, char *spec, char *mode)
 /* findKGAlias Looks up aliases for Known Genes, given a seach spec 
  *   mode "E" is for Exact match
  *   mode "F" is for Fuzzy match
  *   mode "P" is for Prefix match
  * it returns a link list of kgAlias nodes, which contain kgID and Alias */
 {
 struct sqlConnection *conn  = hAllocConn(dataBase);
-struct dyString      *ds    = newDyString(256);
+struct dyString      *ds    = dyStringNew(256);
 struct kgAlias *kaList 	    = NULL;
 char   fullTableName[256];
 
 safef(fullTableName, 250, "%s.%s", dataBase, "kgAlias");
 if (!sqlTableExists(conn, fullTableName))
     {
     errAbort("Table %s.kgAlias does not exist.\n", dataBase);
     }
 
 if (sameString(mode, "E"))
     {
     sqlDyStringPrintf(ds, "select * from %s.kgAlias where alias = '%s'", dataBase, spec);
     }
 else if (sameString(mode, "F"))
     {
     sqlDyStringPrintf(ds, "select * from %s.kgAlias where alias like '%%%s%%'", 
     	dataBase, spec);
     }
 else if (sameString(mode, "P"))
     {
     sqlDyStringPrintf(ds, "select * from %s.kgAlias where alias like '%s%%'", 
     	dataBase, spec);
     }
 addKgAlias(conn, ds, &kaList);
 hFreeConn(&conn);
 return(kaList);
 }