44ccfacbe3a3d4b300f80d48651c77837a4b571e
galt
  Tue Apr 26 11:12:02 2022 -0700
SQL INJECTION Prevention Version 2 - this improves our methods by making subclauses of SQL that get passed around be both easy and correct to use. The way that was achieved was by getting rid of the obscure and not well used functions sqlSafefFrag and sqlDyStringPrintfFrag and replacing them with the plain versions of those functions, since these are not needed anymore. The new version checks for NOSQLINJ in unquoted %-s which is used to include SQL clauses, and will give an error the NOSQLINJ clause is not present, and this will automatically require the correct behavior by developers. sqlDyStringPrint is a very useful function, however because it was not enforced, users could use various other dyString functions and they operated without any awareness or checking for SQL correct use. Now those dyString functions are prohibited and it will produce an error if you try to use a dyString function on a SQL string, which is simply detected by the presence of the NOSQLINJ prefix.

diff --git src/hg/lib/tfbsCons.c src/hg/lib/tfbsCons.c
index 3d59d3f..55c5947 100644
--- src/hg/lib/tfbsCons.c
+++ src/hg/lib/tfbsCons.c
@@ -1,206 +1,206 @@
 /* tfbsCons.c was originally generated by the autoSql program, which also 
  * generated tfbsCons.h and tfbsCons.sql.  This module links the database and
  * the RAM representation of objects. */
 
 /* Copyright (C) 2014 The Regents of the University of California 
  * See kent/LICENSE or http://genome.ucsc.edu/license/ for licensing information. */
 
 #include "common.h"
 #include "linefile.h"
 #include "dystring.h"
 #include "jksql.h"
 #include "tfbsCons.h"
 
 
 void tfbsConsStaticLoad(char **row, struct tfbsCons *ret)
 /* Load a row from tfbsCons table into ret.  The contents of ret will
  * be replaced at the next call to this function. */
 {
 
 ret->chrom = row[0];
 ret->chromStart = sqlUnsigned(row[1]);
 ret->chromEnd = sqlUnsigned(row[2]);
 ret->name = row[3];
 ret->score = sqlUnsigned(row[4]);
 strcpy(ret->strand, row[5]);
 strcpy(ret->species, row[6]);
 strcpy(ret->factor, row[7]);
 strcpy(ret->id, row[8]);
 }
 
 struct tfbsCons *tfbsConsLoad(char **row)
 /* Load a tfbsCons from row fetched with select * from tfbsCons
  * from database.  Dispose of this with tfbsConsFree(). */
 {
 struct tfbsCons *ret;
 
 AllocVar(ret);
 ret->chrom = cloneString(row[0]);
 ret->chromStart = sqlUnsigned(row[1]);
 ret->chromEnd = sqlUnsigned(row[2]);
 ret->name = cloneString(row[3]);
 ret->score = sqlUnsigned(row[4]);
 strcpy(ret->strand, row[5]);
 strcpy(ret->species, row[6]);
 strcpy(ret->factor, row[7]);
 strcpy(ret->id, row[8]);
 return ret;
 }
 
 struct tfbsCons *tfbsConsLoadAll(char *fileName) 
 /* Load all tfbsCons from a whitespace-separated file.
  * Dispose of this with tfbsConsFreeList(). */
 {
 struct tfbsCons *list = NULL, *el;
 struct lineFile *lf = lineFileOpen(fileName, TRUE);
 char *row[9];
 
 while (lineFileRow(lf, row))
     {
     el = tfbsConsLoad(row);
     slAddHead(&list, el);
     }
 lineFileClose(&lf);
 slReverse(&list);
 return list;
 }
 
 struct tfbsCons *tfbsConsLoadAllByChar(char *fileName, char chopper) 
 /* Load all tfbsCons from a chopper separated file.
  * Dispose of this with tfbsConsFreeList(). */
 {
 struct tfbsCons *list = NULL, *el;
 struct lineFile *lf = lineFileOpen(fileName, TRUE);
 char *row[9];
 
 while (lineFileNextCharRow(lf, chopper, row, ArraySize(row)))
     {
     el = tfbsConsLoad(row);
     slAddHead(&list, el);
     }
 lineFileClose(&lf);
 slReverse(&list);
 return list;
 }
 
 struct tfbsCons *tfbsConsLoadByQuery(struct sqlConnection *conn, char *query)
 /* Load all tfbsCons from table that satisfy the query given.  
  * Where query is of the form 'select * from example where something=something'
  * or 'select example.* from example, anotherTable where example.something = 
  * anotherTable.something'.
  * Dispose of this with tfbsConsFreeList(). */
 {
 struct tfbsCons *list = NULL, *el;
 struct sqlResult *sr;
 char **row;
 
 sr = sqlGetResult(conn, query);
 while ((row = sqlNextRow(sr)) != NULL)
     {
     el = tfbsConsLoad(row);
     slAddHead(&list, el);
     }
 slReverse(&list);
 sqlFreeResult(&sr);
 return list;
 }
 
 void tfbsConsSaveToDb(struct sqlConnection *conn, struct tfbsCons *el, char *tableName, int updateSize)
 /* Save tfbsCons as a row to the table specified by tableName. 
  * As blob fields may be arbitrary size updateSize specifies the approx size
  * of a string that would contain the entire query. Arrays of native types are
  * converted to comma separated strings and loaded as such, User defined types are
  * inserted as NULL. Strings are automatically escaped to allow insertion into the database. */
 {
-struct dyString *update = newDyString(updateSize);
+struct dyString *update = dyStringNew(updateSize);
 sqlDyStringPrintf(update, "insert into %s values ( '%s',%u,%u,'%s',%u,'%s','%s','%s','%s')", 
 	tableName,  el->chrom,  el->chromStart,  el->chromEnd,  el->name,  el->score,  el->strand,  el->species,  el->factor,  el->id);
 sqlUpdate(conn, update->string);
-freeDyString(&update);
+dyStringFree(&update);
 }
 
 
 struct tfbsCons *tfbsConsCommaIn(char **pS, struct tfbsCons *ret)
 /* Create a tfbsCons out of a comma separated string. 
  * This will fill in ret if non-null, otherwise will
  * return a new tfbsCons */
 {
 char *s = *pS;
 
 if (ret == NULL)
     AllocVar(ret);
 ret->chrom = sqlStringComma(&s);
 ret->chromStart = sqlUnsignedComma(&s);
 ret->chromEnd = sqlUnsignedComma(&s);
 ret->name = sqlStringComma(&s);
 ret->score = sqlUnsignedComma(&s);
 sqlFixedStringComma(&s, ret->strand, sizeof(ret->strand));
 sqlFixedStringComma(&s, ret->species, sizeof(ret->species));
 sqlFixedStringComma(&s, ret->factor, sizeof(ret->factor));
 sqlFixedStringComma(&s, ret->id, sizeof(ret->id));
 *pS = s;
 return ret;
 }
 
 void tfbsConsFree(struct tfbsCons **pEl)
 /* Free a single dynamically allocated tfbsCons such as created
  * with tfbsConsLoad(). */
 {
 struct tfbsCons *el;
 
 if ((el = *pEl) == NULL) return;
 freeMem(el->chrom);
 freeMem(el->name);
 freez(pEl);
 }
 
 void tfbsConsFreeList(struct tfbsCons **pList)
 /* Free a list of dynamically allocated tfbsCons's */
 {
 struct tfbsCons *el, *next;
 
 for (el = *pList; el != NULL; el = next)
     {
     next = el->next;
     tfbsConsFree(&el);
     }
 *pList = NULL;
 }
 
 void tfbsConsOutput(struct tfbsCons *el, FILE *f, char sep, char lastSep) 
 /* Print out tfbsCons.  Separate fields with sep. Follow last field with lastSep. */
 {
 if (sep == ',') fputc('"',f);
 fprintf(f, "%s", el->chrom);
 if (sep == ',') fputc('"',f);
 fputc(sep,f);
 fprintf(f, "%u", el->chromStart);
 fputc(sep,f);
 fprintf(f, "%u", el->chromEnd);
 fputc(sep,f);
 if (sep == ',') fputc('"',f);
 fprintf(f, "%s", el->name);
 if (sep == ',') fputc('"',f);
 fputc(sep,f);
 fprintf(f, "%u", el->score);
 fputc(sep,f);
 if (sep == ',') fputc('"',f);
 fprintf(f, "%s", el->strand);
 if (sep == ',') fputc('"',f);
 fputc(sep,f);
 if (sep == ',') fputc('"',f);
 fprintf(f, "%s", el->species);
 if (sep == ',') fputc('"',f);
 fputc(sep,f);
 if (sep == ',') fputc('"',f);
 fprintf(f, "%s", el->factor);
 if (sep == ',') fputc('"',f);
 fputc(sep,f);
 if (sep == ',') fputc('"',f);
 fprintf(f, "%s", el->id);
 if (sep == ',') fputc('"',f);
 fputc(lastSep,f);
 }
 
 /* -------------------------------- End autoSql Generated Code -------------------------------- */