1b074613b1c6b7f84953c3f490631b91d844c9a9
galt
  Thu Sep 8 22:40:20 2022 -0700
Adapting Angie's existing variant effects to the new dbSnp that uses SPDI and provided via json formatted data. So users can see variant effects with version 153 or later. refs #29989

diff --git src/hg/js/subCfg.js src/hg/js/subCfg.js
index a36da42..641e8a8 100644
--- src/hg/js/subCfg.js
+++ src/hg/js/subCfg.js
@@ -5,30 +5,37 @@
 // opened.  Composite and view level controls (parents) when updated override related
 // subtrack controls (children).  Subtrack controls, when updated overide parent controls
 // for the one subtrack.  Controls wil get class 'changed' added when changes are made.
 // When the form is submitted, all controls not marked as "changed" will be unnamed and will
 // therefore not make it into the cart.
 
 // Definitions as used here:
 // obj: an input or select style html control which may be marked as "changed"
 //   parentObj: composite or view level obj which has subtrack level childObjs associated
 //   childObj: subtrack level obj that has composite and or view level parentObjs
 // cfg: subtrack level embedded dialog which can be opened or closed (hidden) and isn't
 //      populated till first opened.  Can also be a viewCfg and maybe a compositeCfg
 // populate: act of filling a subtrack cfg with controls
 // fauxVis: fake control for subtrack visDD, which will be replaced with true vis when clicked.
 //
+// NOTE: there is code inside hgTracks and cart.c that is removing subtrack values in the cart
+//    hgTracks.c::parentChildCartCleanup() uses oldVars and calls cart.c::cartTdbTreeCleanupOverrides().
+//    It seems to have a long-existing bug such that if you make two changes to the view level at once before submitting,
+//    the cart ends up with incorrect state as seen by reloading in hgTrackUi.
+//    Making one change to view and one change to subtrack and then submitting also causes the problem.
+//    If you only make one change at a time to an element and submit then it works.
+//
 // NOTE:
 // Current implementation relies upon '.' delimiter in name and no '_-' in name.
 //   Nothing breaks rule yet...
 
 // Don't complain about line break before '||' etc:
 /* jshint -W014 */
 
 var subCfg = { // subtrack config module.
     //mySelf: null, // There is no need for a "mySelf" unless this object is being instantiated.
 
     // There is one instance and these vars are page wide
     compositeName: undefined,
     canPack: true,  // if composite vis is only hide,dense,full, then all children also restricted.
     visIndependent: false,
     viewTags: [],