c0af5f216f8ff00466f0d222cede7f491fd17d81 galt Fri Jan 20 23:09:35 2023 -0800 More fixes for stuff found by htmlCheck, refs #7914 diff --git src/hg/near/hgNear/hgNear.c src/hg/near/hgNear/hgNear.c index 8720159..00206d9 100644 --- src/hg/near/hgNear/hgNear.c +++ src/hg/near/hgNear/hgNear.c @@ -1068,47 +1068,47 @@ /* Make genome drop-down. */ hPrintf("genome "); hPrintf("<SELECT id='org_sel' NAME=\"%s\">\n", orgVarName); jsOnEventById("change", "org_sel", "document.orgForm.org.value=document.mainForm.org.options[document.mainForm.org.selectedIndex].value;" "document.orgForm.db.value=0;" "document.orgForm.submit();"); for (org = orgList; org != NULL; org = org->next) { struct dbDb *db = org->val; char *genome = db->genome; hPrintf("<OPTION VALUE=\"%s\"", genome); if (sameString(ourOrg, genome)) hPrintf(" SELECTED"); - hPrintf(">%s\n", genome); + hPrintf(">%s</OPTION>\n", genome); } hPrintf("</SELECT>"); /* Make assembly drop-down. */ hPrintf(" assembly "); hPrintf("<SELECT id='db_sel' NAME=\"%s\">\n", dbVarName); jsOnEventById("change", "db_sel", "document.orgForm.db.value = document.mainForm.db.options[document.mainForm.db.selectedIndex].value;" "document.orgForm.submit();"); for (as = asList; as != NULL; as = as->next) { struct dbDb *db = as->val; hPrintf("<OPTION VALUE=\"%s\"", db->name); if (sameString(database, db->name)) hPrintf(" SELECTED"); - hPrintf(">%s\n", db->description); + hPrintf(">%s</OPTION>\n", db->description); } hPrintf("</SELECT>"); /* Clean up time. */ slFreeList(&asList); slFreeList(&orgList); hashFree(&orgHash); dbDbFree(&dbList); } void controlPanelStart() /* Put up start of tables around a control panel. */ { hPrintf("<TABLE WIDTH=\"100%%\" BORDER=0 CELLSPACING=0 CELLPADDING=4><TR><TD ALIGN=CENTER>"); hPrintf("<TABLE BORDER=1 CELLSPACING=0 CELLPADDING=0 BGCOLOR=\"#"HG_COL_BORDER"\"><TR><TD>"); @@ -1160,31 +1160,31 @@ hPrintf("\">"); hPrintf("sort by"); hPrintf("</A> "); hPrintf("<SELECT id='sort_sel' NAME=\"%s\">\n", orderVarName); jsOnEventByIdF("change", "sort_sel", "document.orgForm.%s.value = document.mainForm.%s.options[document.mainForm.%s.selectedIndex].value;" "document.orgForm.submit();", orderVarName, // XSS Filter GALT TODO orderVarName, orderVarName); for (ord = ordList; ord != NULL; ord = ord->next) { hPrintf("<OPTION VALUE=\"%s\"", ord->name); if (ord == curOrd) hPrintf(" SELECTED"); - hPrintf(">%s\n", ord->shortLabel); + hPrintf(">%s</OPTION>\n", ord->shortLabel); } hPrintf("</SELECT>\n"); } /* advFilter, configure buttons */ { cgiMakeButton(confVarName, "configure"); hPrintf(" "); if (gotAdvFilter()) cgiMakeButton(advFilterVarName, "filter (now on)"); else cgiMakeButton(advFilterVarName, "filter (now off)"); hPrintf(" "); } @@ -1194,31 +1194,31 @@ int i = 0; hPrintf(" display "); hPrintf("<SELECT id='display_sel' NAME=\"%s\">\n", countVarName); jsOnEventByIdF("change", "display_sel", "document.orgForm.%s.value = document.mainForm.%s.options[document.mainForm.%s.selectedIndex].value;" "document.orgForm.submit();", countVarName, countVarName, countVarName); for (i = 0; i < ArraySize(menu); ++i) { hPrintf("<OPTION VALUE=\"%s\"", menu[i]); if (sameString(displayCountString, menu[i])) hPrintf(" SELECTED"); - hPrintf(">%s\n", menu[i]); + hPrintf(">%s</OPTION>\n", menu[i]); } hPrintf("</SELECT>\n"); } /* Make getDna, getText buttons */ { hPrintf(" output "); cgiMakeOptionalButton(getSeqPageVarName, "sequence", gp == NULL); hPrintf(" "); cgiMakeOptionalButton(getTextVarName, "text", gp == NULL); } controlPanelEnd(); }