3fc35a6a1ae672294df62eeec6e0e153a39605f9 hiram Thu May 11 15:05:52 2023 -0700 correct target=_blank on chromSizes and chromAlias URLs on "sequence" page refs #31257 diff --git src/hg/hgTracks/hgTracks.c src/hg/hgTracks/hgTracks.c index 7ffe11b..f74ff9a 100644 --- src/hg/hgTracks/hgTracks.c +++ src/hg/hgTracks/hgTracks.c @@ -10663,74 +10663,74 @@ } sqlFreeResult(&sr); hFreeConn(&conn); } static void chromSizesDownloadRow(boolean hasAlias, char *hubAliasFile, char *chromSizesFile) /* Show link to chrom.sizes file at end of chromInfo table (unless this is a hub) */ { if (! trackHubDatabase(database)) { cgiSimpleTableRowStart(); cgiSimpleTableFieldStart(); puts("Download as file:"); cgiTableFieldEnd(); cgiSimpleTableFieldStart(); - printf("<A HREF='http://%s/goldenPath/%s/bigZips/%s.chrom.sizes'>%s.chrom.sizes</A>", + printf("<a href='http://%s/goldenPath/%s/bigZips/%s.chrom.sizes' target=_blank>%s.chrom.sizes</a>", hDownloadsServer(), database, database, database); cgiTableFieldEnd(); if (hasAlias) { cgiSimpleTableFieldStart(); /* see if this database has the chromAlias.txt download file */ char aliasFile[1024]; safef(aliasFile, sizeof aliasFile, "http://%s/goldenPath/%s/bigZips/%s.chromAlias.txt", hDownloadsServer(), database, database); struct udcFile *file = udcFileMayOpen(aliasFile, udcDefaultDir()); if (file) { udcFileClose(&file); - printf("<A HREF='%s'>%s.chromAlias.txt</A>", aliasFile, database); + printf("<a href='%s' target=_blank>%s.chromAlias.txt</a>", aliasFile, database); } else puts(" "); cgiTableFieldEnd(); } cgiTableRowEnd(); } else if (hubAliasFile) { cgiSimpleTableRowStart(); cgiSimpleTableFieldStart(); puts("Download as file:"); cgiTableFieldEnd(); cgiSimpleTableFieldStart(); if (chromSizesFile) { - printf("<a href='%s' target=_blank>%s.chrom.sizes.txt</A>", chromSizesFile, trackHubSkipHubName(database)); + printf("<a href='%s' target=_blank>%s.chrom.sizes.txt</a>", chromSizesFile, trackHubSkipHubName(database)); puts(" "); } else puts(" "); cgiTableFieldEnd(); cgiSimpleTableFieldStart(); char *aliasUrl = cloneString(hubAliasFile); /* this URL reference needs to be a text file to work as a click in the * html page. Both files chromAlias.bb and chromAlias.txt exist. */ if (endsWith(hubAliasFile, "chromAlias.bb")) aliasUrl = replaceChars(hubAliasFile, "chromAlias.bb", "chromAlias.txt"); - printf("<a href='%s' target=_blank>%s.chromAlias.txt</A>", aliasUrl, trackHubSkipHubName(database)); + printf("<a href='%s' target=_blank>%s.chromAlias.txt</a>", aliasUrl, trackHubSkipHubName(database)); cgiTableFieldEnd(); cgiTableRowEnd(); } } void chromInfoPage() /* Show list of chromosomes (or scaffolds, etc) on which this db is based. */ { boolean hasAlias = FALSE; char *chromSizesFile = NULL; char *aliasFile = NULL; if (trackHubDatabase(database)) { /* either one of these files present will work */ aliasFile = trackHubAliasFile(database); if (aliasFile)