8e415e6f438aac63ed1feb3865c757a74c606606 gperez2 Tue Jun 11 12:07:22 2024 -0700 Code review edits, refs #33833 diff --git src/utils/qa/checkSessionsFromRR.py src/utils/qa/checkSessionsFromRR.py index 51f4e85..d1fb066 100755 --- src/utils/qa/checkSessionsFromRR.py +++ src/utils/qa/checkSessionsFromRR.py @@ -81,172 +81,171 @@ write_session_settings.close() return session_settings def loadSessionhgw0(session, machine): """Makes session URL to load on hgw0""" session=session.split('qateam')[1] session=machine+server+session return session def checkSessionhgw0(session): """Checks if session loads on hgw0""" #String to check when hgTracks finishes loading check_hgTracks='// END hgTracks' try: - checkLoad=bash("curl -Ls '"+session+"'") + checkLoad=bash("curl -Ls '%s'" % session) try: - checkLoad=bash("curl -Ls '"+session+"'") + checkLoad=bash("curl -Ls '%s'" % session) checkLoad=str(checkLoad)[1:-1] #If the string to check when hgTracks finishes loading is present then save the session to a variable if check_hgTracks in checkLoad: sessionLoads=session else: # If string is not present then delete the file with the session contents sessionLoads='no' session_dir=session.split('genecats.gi.ucsc.edu')[1] session_path=myDir+session_dir # Uncomment the line below to actually remove the session files #os.system('rm '+session_path) - except subprocess.CalledProcessError as e: + except subprocess.CalledProcessError: sessionLoads='no' - except subprocess.CalledProcessError as e: + except subprocess.CalledProcessError: sessionLoads='no' return sessionLoads def loadSession(session, machine): """Makes session URL to load on machine""" session=session.split('cgi-bin')[1] session=machine+session return session def checkSession(session): """Checks if session loads on machine""" #Strings to check check_hgTracks='// END hgTracks' check_error='<!-- ERROR -->' check_warning="id='warnBox'" hubid_error="Couldn't connect to database hub_" hubid_error_dev="can not find any trackDb tables for hub_" # List to append session load error error_list=[] try: - checkLoad=bash("curl -Ls '"+session+"'") + checkLoad=bash("curl -Ls '%s'" % session) checkLoad=str(checkLoad)[1:-1] #If session contains strings to check if session loaded, set a variable that session loaded if check_hgTracks in checkLoad: if check_error in checkLoad: #checks if there is an error when session is loaded if check_warning in checkLoad: #checks if the error is a warning when session is loaded check3='loads' else: #If session contains the error string to check, add error to list error_list.append('error') check2='loads' #Pass if session load error is Couldn't connect to database hub error (hub id issue) elif hubid_error in checkLoad: pass #Pass if session load error is can not find any trackDb tables for hub_ ((hub id issue)) elif hubid_error_dev in checkLoad: pass else: #If session does not contains strings to check, add error to list error_list.append('error') except subprocess.CalledProcessError as e: #If session fails to curl, add error to list error_list.append('error') #If an error is present in the error list, save the session URL to variable if 'error' in error_list: sessionLoad=session - else: #If no error is present in the error list, set variable that session loaeded + else: #If no error is present in the error list, set variable that session loaded sessionLoad='loads' session_dir=session.split('genecats.gi.ucsc.edu')[1] session_path=myDir+session_dir #Uncomment the line below to actually remove the session files - #os.system('rm '+session_path) + os.system('rm '+session_path) return sessionLoad def makeURL(session, url_txt, count): """Creates a text file that appends crash sessions""" failed_session=open(url_txt, 'a') failed_session.write(str(datetime.now().strftime("%Y-%m-%d %H:%M:%S"))+'\t'+str(session)+'\n') failed_session.close() return session def output_if_file_exists(file_path): """Outputs if text file was created for crash sessions""" if os.path.exists(file_path): print("This cronjob outputs sessions that crash on hgwbeta or hgwdev. The session URLs have '#' in ...session_settings_#.txt which is the random number session tested") with open(file_path, 'r') as file: print() print(file.read()) print("\nErrors that output 'hui::wiggleScaleStringToEnum() - Unknown option' can be ignored.") -#Remove session contents files -os.system("rm /hive/users/qateam/sessionsFromRR/*") - - year=datetime.now().strftime("%Y-%m-"+"01") server='https://genecats.gi.ucsc.edu/qa/qaCrons' #Saves the montly hgcentral session dump to a varaiable monthly_hgcentral_dump="/usr/local/apache/htdocs-genecats/qa/test-results/hgcentral/"+year+"/rr.namedSessionDb" count=0 #Machine partial URL to load session hgw0='http://hgw0.soe.ucsc.edu/cgi-bin/hgTracks?hgS_doLoadUrl=submit&hgS_loadUrlName=' hgwbeta='http://hgwbeta.soe.ucsc.edu/cgi-bin' hgwdev='http://hgwdev.gi.ucsc.edu/cgi-bin' #Path to file to append crash sessions url_txt='/usr/local/apache/htdocs-genecats/qa/qaCrons/sessionsFromRR/crashedSessions.txt' #Directory to save files for the script myDir='/usr/local/apache/htdocs-genecats' -#num_lines=10000 # Number of random lines to select num_lines=10000 # Number of random lines to select #Gets a number of random of sessions from the monthly_hgcentral_dump random_lines = random_session_lines(monthly_hgcentral_dump, num_lines) def main(random_lines, server, count, hgw0, hgwbeta, hgwdev, url_txt, myDir): """ Gets a number of random of sessions from the RR, if sessions crash on hgwdev/hgwbeta then outputs the crash sessions""" + #Remove session contents files + os.system("rm /hive/users/qateam/sessionsFromRR/*") + for line in random_lines: count=count +1 session_contents=parseSessions(line) if session_contents=='missing': continue session=getSessionContents(session_contents, count) hgw0session=loadSessionhgw0(session, hgw0) session=checkSessionhgw0(hgw0session) if session=='no': continue hgwbetaSession=loadSession(session, hgwbeta) beta_session=checkSession(hgwbetaSession) if beta_session=='loads': pass else: makeURL(beta_session, url_txt, count) hgwdevSession=loadSession(session, hgwdev) dev_session=checkSession(hgwdevSession) if dev_session=='loads': continue else: makeURL(dev_session, url_txt, count) output_if_file_exists(url_txt) -main(random_lines, server, count, hgw0, hgwbeta, hgwdev, url_txt, myDir) +if __name__ == "__main__": + sys.exit(main(random_lines, server, count, hgw0, hgwbeta, hgwdev, url_txt, myDir)) # Program Output (Commented out) #This cronjob outputs sessions that crash on hgwbeta or hgwdev. The session URLs have '#' in ...session_settings_#.txt which is the random number session tested #2024-05-09 00:21:25 http://hgwbeta.soe.ucsc.edu/cgi-bin/hgTracks?hgS_doLoadUrl=submit&hgS_loadUrlName=https://genecats.gi.ucsc.edu/qa/qaCrons/sessionsFromRR/session_settings_4642.txt #2024-05-09 00:21:56 http://hgwdev.gi.ucsc.edu/cgi-bin/hgTracks?hgS_doLoadUrl=submit&hgS_loadUrlName=https://genecats.gi.ucsc.edu/qa/qaCrons/sessionsFromRR/session_settings_4642.txt #Errors that output 'hui::wiggleScaleStringToEnum() - Unknown option' can be ignored.