d545453f0d97807bb471417a70e4a15db50fbe2a lrnassar Wed Jan 22 12:28:51 2025 -0800 Fixing a small bug where if the hub URL was http but the query to their server failed, it would still try to initialize text=f.txt even though the request never worked. The FTP example already had it in the proper location. No RM. diff --git src/utils/qa/hubPublicMail src/utils/qa/hubPublicMail index bf3c2ebd24c..6e01ed7b114 100755 --- src/utils/qa/hubPublicMail +++ src/utils/qa/hubPublicMail @@ -86,35 +86,35 @@ return s.split(" or ")[1] return s def downloadUrls(urls, emails): " try to read all hub.txt in URLs, return list of failed URLs, and dict hub -> email" didFail = list() emails = dict() for url in urls: logging.debug("Checking %s" % url) reqFailed = False if url.startswith("http"): try: f = requests.get(url, verify=False, timeout=5) + text = f.text except KeyboardInterrupt: # handle ctrl-c for debugging sys.exit(1) except: reqFailed = True - text = f.text else: # FTP try: f = urllib.request.urlopen(url, timeout=10) text = f.read().decode("utf8") except: reqFailed = True if reqFailed: logging.debug("URL %s failed." % url) didFail.append(url) continue lines = text.splitlines() for l in lines: