61dc7885a5f1001e2bc189501379088f2b53379d galt Mon Feb 23 15:42:36 2026 -0800 fixes things found automated codereview. for bigBedCmdSupport lib moved slAddHead, removed stray debugmsg and fixed comment and added static keyword. fixed bigChainToChain chromFound = FALSE, removed stray test makefile, fixed existing typo "tines", and added a missing space after issing space before optionMultiVal(). refs #37146 diff --git src/hg/utils/bigChainToChain/bigChainToChain.c src/hg/utils/bigChainToChain/bigChainToChain.c index caea7e87a4c..19e572ae3d6 100644 --- src/hg/utils/bigChainToChain/bigChainToChain.c +++ src/hg/utils/bigChainToChain/bigChainToChain.c @@ -51,62 +51,62 @@ static struct optionSpec options[] = { {"chrom", OPTION_STRING}, {"start", OPTION_INT}, {"end", OPTION_INT}, {"bed", OPTION_STRING}, {"range", OPTION_STRING|OPTION_MULTI}, {"positions", OPTION_STRING}, {"udcDir", OPTION_STRING}, {"skipChromCheck", OPTION_BOOLEAN}, {NULL, 0}, }; static void processChromChunk(struct bbiFile *bbi, char *chrom, int start, int end, char *bedName, FILE *f) /* Output one chunk. Only blocks where start is in the range will be written - * to avoid outputting a block multiple tines. */ + * to avoid outputting a block multiple times. */ { char *chromName = chrom; struct chain *chains = chainLoadIdRangeHub(NULL, inChain, inLinks, chromName, start, end, -1); chainWriteAll(chains, f); } void bigChainToChain(char *out) /* bigChainArrange - output a set of rearrangement breakpoints. */ { struct bbiFile *bbi = bigBedFileOpen(inChain); FILE *f = mustOpen(out, "w"); struct bbiChromInfo *chrom, *chromList = bbiChromList(bbi); if (!skipChromCheck) chromHash = makeChromHash(chromList); if (clBed != NULL) { genericBigToNonBigFromBed(bbi, chromHash, clBed, f, &processChromChunk); } else if (clPos != NULL) { genericBigToNonBigFromPos(bbi, chromHash, clPos, f, &processChromChunk); } else if (clRange != NULL) { genericBigToNonBigFromRange(bbi, chromHash, f, clRange, &processChromChunk); } else { - boolean chromFound; + boolean chromFound = FALSE; for (chrom = chromList; chrom != NULL; chrom = chrom->next) { if (clChrom != NULL && !sameString(clChrom, chrom->name)) continue; chromFound = TRUE; int start = 0, end = chrom->size; if (clStart >= 0) start = clStart; if (clEnd >= 0) { end = clEnd; if (end > chrom->size) end = chrom->size; }