7eb59a7b92b6256391c21256af4033ae03fff257 hiram Fri Mar 20 16:39:11 2026 -0700 minor issues discovered by claude code review diff --git src/hg/hgTrackUi/hgTrackUi.c src/hg/hgTrackUi/hgTrackUi.c index 8bfeb9a343c..159922689e5 100644 --- src/hg/hgTrackUi/hgTrackUi.c +++ src/hg/hgTrackUi/hgTrackUi.c @@ -2272,31 +2272,31 @@ printf("<input name='%s' id='%s' size=\"%d\" value=\"%s\" type=\"TEXT\">", oligoMatchVar, oligoMatchVar, 45, oligo); puts("<br>Examples: TATAWAAR, AAAAA"); jsOnEventById("input", oligoMatchVar, "packTrack();"); puts("<P><B>Search strand:</B> "); cgiMakeRadioButton(oligoMatchStrandVar, "both", sameString(strand, "both")); puts(" Both "); cgiMakeRadioButton(oligoMatchStrandVar, "forward", sameString(strand, "forward")); puts(" Forward (+) "); cgiMakeRadioButton(oligoMatchStrandVar, "reverse", sameString(strand, "reverse")); puts(" Reverse (-) "); } static void gcOnFlyUi(struct trackDb *tdb) -/* UI for oligo match track */ +/* UI for GC on the fly track */ { char *winSize = cartUsualString(cart, gcOnFlyWindowSize, gcOnFlyDefaultSize); puts("<P><B>GC Percent calculation window size: </B>"); jsInline( "function fullTrack()\n" "{\n" "var box = jQuery('select[name$=gcOnFly]');\n" "if (box.val()=='hide')\n" " box.val('full');\n" "}\n"); printf("<input name='%s' id='%s' size=\"%d\" value=\"%s\" type=\"TEXT\">", gcOnFlyWindowSize, gcOnFlySizeVar, 15, winSize); jsOnEventById("input", gcOnFlySizeVar, "fullTrack();"); puts("<P>UCSC standard window size is 5 bases. Adjust size as desired.</P>"); /* Add standard wiggle graph controls (height, scale, graph type, smoothing, etc.) */ @@ -4003,31 +4003,31 @@ /* Create a trackDb entry for the wikiTrack. It is not a real track, so doesn't appear in trackDb */ { return trackDbForPseudoTrack(WIKI_TRACK_TABLE, WIKI_TRACK_LABEL, WIKI_TRACK_LONGLABEL, tvFull, FALSE); } struct trackDb *trackDbForRuler() /* Create a trackDb entry for the base position ruler. It is not (yet?) a real track, so doesn't appear in trackDb */ { return trackDbForPseudoTrack(RULER_TRACK_NAME, RULER_TRACK_LABEL, RULER_TRACK_LONGLABEL, tvFull, FALSE); } -static struct trackDb *trackDbForGcOnFly() +static struct trackDb *trackDbForGcOnFly(struct cart *cart) /* Create a trackDb entry for the GC on the fly pseudo-track. */ { char longLabel[1024]; safef(longLabel, sizeof(longLabel), "GC FLY Percent in %s-Base Windows", gcOnFlyWinSize(cart)); struct trackDb *tdb = trackDbForPseudoTrack(GC_ON_FLY_TRACK_NAME, GC_ON_FLY_TRACK_LABEL, longLabel, tvFull, TRUE); tdb->canPack = 0; return tdb; } struct trackDb *trackDbForOligoMatch() /* Create a trackDb entry for the oligo matcher pseudo-track. */ { return trackDbForPseudoTrack(OLIGO_MATCH_TRACK_NAME, OLIGO_MATCH_TRACK_LABEL, OLIGO_MATCH_TRACK_LONGLABEL, tvHide, TRUE);