735a45a2ff3e444fe9d668584ad5d221046f0417 hiram Wed May 6 09:02:07 2026 -0700 correctly reset form after display of existing alignment refs #31811 diff --git src/hg/js/liftRequest.js src/hg/js/liftRequest.js index dd08ec7b486..bcdfe68ce52 100644 --- src/hg/js/liftRequest.js +++ src/hg/js/liftRequest.js @@ -83,45 +83,52 @@ } }); } }) .catch(error => { console.error("Error fetching liftOver list:", error); }); } // end of function checkAssemblyCompatibility(asm1, asm2) function checkBothAssembliesSelected() { if (genome1 && genome2) { // Both assemblies are now selected checkAssemblyCompatibility(genome1, genome2); } } +function resetFormVisibility() { + document.getElementById("liftExists").style.display = "none"; + document.getElementById("emailForm").style.display = "block"; + document.getElementById("commentsForm").style.display = "block"; + document.getElementById("submitButton").style.display = "block"; +} + function assembly1Select(selectEle, item) { selectEle.innerHTML = item.label; assembly1Value = item.value || item.label; genome1 = item.genome; // console.log("asm1:", JSON.stringify(item, null, 2)); - document.getElementById("liftExists").style.display = "none"; + resetFormVisibility(); checkBothAssembliesSelected(); } function assembly2Select(selectEle, item) { selectEle.innerHTML = item.label; assembly2Value = item.value || item.label; genome2 = item.genome; // console.log("asm2:", JSON.stringify(item, null, 2)); - document.getElementById("liftExists").style.display = "none"; + resetFormVisibility(); checkBothAssembliesSelected(); } function validateEmail(checkEmail) { // Require at least one dot in domain var validEmail = /^[a-zA-Z0-9.!#$%&'*+/=?^_`{|}~-]+@[a-zA-Z0-9-]+(?:\.[a-zA-Z0-9-]+)+$/; if (!validEmail.test(checkEmail)) { alert("You have entered an invalid email address !"); return false; } return true; } function submitForm() { @@ -176,34 +183,31 @@ } document.getElementById("errorText").textContent = errorMsg; document.getElementById("errorMessage").style.display = "block"; } }); }) .catch((error) => { // Network or other fetch errors var errorMsg = error.message || "Unknown error occurred"; document.getElementById("errorText").textContent = errorMsg; document.getElementById("errorMessage").style.display = "block"; }); } // end of function submitForm() function dismissLiftExists() { - document.getElementById("liftExists").style.display = "none"; - document.getElementById("emailForm").style.display = "block"; - document.getElementById("commentsForm").style.display = "block"; - document.getElementById("submitButton").style.display = "block"; + resetFormVisibility(); document.getElementById("genomeSearch1").value = ""; document.getElementById("genomeSearch2").value = ""; assembly1Value = ""; assembly2Value = ""; genome1 = ""; genome2 = ""; } function onSearchError(jqXHR, textStatus, errorThrown, term) { return [{label: 'No genomes found', value: '', genome: '', disabled: true}]; } document.addEventListener("DOMContentLoaded", () => { // Assembly 1 autocomplete let selectEle1 = document.getElementById("genomeLabel1");