113937fa86799fcf930f93aade0355a698088982 hiram Tue Apr 21 12:45:53 2026 -0700 fixups to avoid jshint errors refs #31811 diff --git src/hg/js/liftRequest.js src/hg/js/liftRequest.js index 5a994a80fe7..4b97f229c85 100644 --- src/hg/js/liftRequest.js +++ src/hg/js/liftRequest.js @@ -1,15 +1,16 @@ +/* jshint esnext: true */ var assembly1Value = ""; var assembly2Value = ""; var genome1 = ""; var genome2 = ""; /* check if a file exists at the specified URL */ function fileExists(url, callback) { fetch(url, { method: 'HEAD' }) .then(response => { callback(response.ok); }) .catch(() => { callback(false); }); } @@ -144,68 +145,55 @@ } if (! validateEmail(email)) { return; } // Build the API URL with query parameters var comment = comments.slice(0, 1000); // make sure that URL is not too long comment += ", from: " + assembly1Value + ", to: " + assembly2Value; var apiUrl = "/cgi-bin/hubApi/liftRequest?" + "fromGenome=" + encodeURIComponent(genome1) + ";" + "toGenome=" + encodeURIComponent(genome2) + ";" + "email=" + encodeURIComponent(email) + ";" + "comment=" + encodeURIComponent(comment); fetch(apiUrl, { method: 'GET' }) - .then(async (response) => { + .then((response) => { + return response.text().then((text) => { if (response.ok) { - const data = await response.json().catch(() => null); // parse JSON if any -// console.log(JSON.stringify(data)); localStorage.setItem('liftRequestEmail', email); document.getElementById("formContainer").style.display = "none"; document.getElementById("successMessage").style.display = "block"; } else { // Try to extract error message from JSON or text - let errorMsg = "Error submitting request"; + var errorMsg = "Error submitting request"; try { - const errorData = await response.json(); - if (errorData && errorData.error) { - errorMsg = errorData.error; - } else { - errorMsg = response.statusText || errorMsg; - } - } catch { - // If JSON parse fails, try plain text - const text = await response.text(); - try { - const parsed = JSON.parse(text); + var parsed = JSON.parse(text); if (parsed.error) { errorMsg = parsed.error; - } else { - errorMsg = text || errorMsg; - } - } catch { - errorMsg = response.statusText || errorMsg; } + } catch(e) { + errorMsg = text || response.statusText || errorMsg; } document.getElementById("errorText").textContent = errorMsg; document.getElementById("errorMessage").style.display = "block"; } + }); }) .catch((error) => { // Network or other fetch errors - const errorMsg = error.message || "Unknown error occurred"; + var errorMsg = error.message || "Unknown error occurred"; document.getElementById("errorText").textContent = errorMsg; document.getElementById("errorMessage").style.display = "block"; }); } // end of function submitForm() function dismissLiftExists() { document.getElementById("liftExists").style.display = "none"; document.getElementById("emailForm").style.display = "block"; document.getElementById("commentsForm").style.display = "block"; document.getElementById("submitButton").style.display = "block"; document.getElementById("genomeSearch1").value = ""; document.getElementById("genomeSearch2").value = ""; assembly1Value = ""; assembly2Value = ""; genome1 = "";