a1d7c07c50f1d895337de121680ea672b261c058
max
Mon Aug 17 02:26:36 2026 -0700
escape reflected/echoed user input across several CGIs (XSS), refs #38057
Route user-, DB- and hub-derived values through htmlEncode (HTML/attribute text),
cgiEncode (values composed into URLs), jsonStringEscape (values placed in a JS string
literal inside an inline script) or, for hgMirror, the existing mustBeClean sanitizer.
Covers hgHubConnect, hgUserSuggestion, hgLiftOver, hgBlat, hgc pubs, hgVisiGene,
hgSession, hgTrackUi, hgGenome, phyloPng, hgFileSearch, hgLinkIn, hgPal, hui,
hgPhyloPlace, hgMirror, hgCustom and hgSearch.
diff --git src/hg/hgGenome/browseRegions.c src/hg/hgGenome/browseRegions.c
index 5d056c9016d..02ec7a4d039 100644
--- src/hg/hgGenome/browseRegions.c
+++ src/hg/hgGenome/browseRegions.c
@@ -29,44 +29,44 @@
{
struct genoGraph *gg = ggFirstVisible();
double threshold = getThreshold();
struct bed3 *bed, *bedList = regionsOverThreshold(gg);
/* Define names of our two frames. */
char *browserFrame = "browser";
char *indexFrame = "index";
/* Write index html file. */
struct tempName indexTn;
trashDirFile(&indexTn, "hgg", "index", ".html");
FILE *f = mustOpen(indexTn.forCgi, "w");
htmStart(f, "Region Index");
fprintf(f, "");
-fprintf(f, "%s
\n", gg->shortLabel);
+fprintf(f, "%s
\n", htmlEncode(gg->shortLabel)); // user graph label, escape (XSS)
fprintf(f, "%3.1f Mb in
\n",
0.000001*bedTotalSize((struct bed*)bedList));
fprintf(f, "%d regions > %g
\n",
slCount(bedList), threshold);
for (bed = bedList; bed != NULL; bed = bed->next)
{
fprintf(f, "", browserFrame);
fprintf(f, "%s %3.1fM to %3.1fM
",
bed->chrom, 0.000001*bed->chromStart, 0.000001*bed->chromEnd);
}
fprintf(f, "\n");
carefulClose(&f);
/* Write frames */
hPrintf("\n");
hPrintf("\n%s%s Regions >= %g\n",
- getCspMetaHeader(), gg->shortLabel, threshold);
+ getCspMetaHeader(), htmlEncode(gg->shortLabel), threshold);
hPrintf("\n");
hPrintf("\n");
}