5ee674363623678393bb186b1f5fdfd981ee743f braney Mon Aug 17 10:35:26 2026 -0700 hgTracks: default multiRegionButtonTop TRUE in config.c too, refs #37977 Two places read multiRegionButtonTop through MULTI_REGION_CFG_BUTTON_TOP: the top-bar Multi-region button in hgTracks.c and the "Show all" checkbox in the multi-region dialog in config.c. Kate put the checkbox under this flag on purpose in 8ae222adb54. Then e1f7896a08f turned the flag on by default in 2022 and changed only the hgTracks.c read, so on a machine that does not set the flag the button moved to the top bar while the checkbox stayed hidden. It has been hidden for four years, although the cart variable it sets is read unconditionally at hgTracks.c:11115, so the feature works for anyone who can reach the variable another way. The hg.conf catalog row carried this as an open defect, so its note is rewritten and its recorded default now matches the tree. diff --git src/hg/hgTracks/config.c src/hg/hgTracks/config.c index 67ce31d969e..fecdf3b03bf 100644 --- src/hg/hgTracks/config.c +++ src/hg/hgTracks/config.c @@ -1,1199 +1,1199 @@ /* config - put up track and display configuration page. */ /* Copyright (C) 2014 The Regents of the University of California * See kent/LICENSE or http://genome.ucsc.edu/license/ for licensing information. */ #include "common.h" #include "dystring.h" #include "cheapcgi.h" #include "htmshell.h" #include "hdb.h" #include "hCommon.h" #include "cart.h" #include "web.h" #include "customTrack.h" #include "hgTracks.h" #include "trashDir.h" #include "hgConfig.h" #include "jsHelper.h" #include "imageV2.h" #include "search.h" #include "hubConnect.h" #include "fileUi.h" #include "trackHub.h" #include "versionInfo.h" static void themeDropDown(struct cart* cart) /* Create drop down for UI themes. * specfied in hg.conf like this * browser.theme.modern=background.png,HGStyle * */ { struct slName* themes = cfgNamesWithPrefix("browser.theme."); if (themes==NULL) return; slNameSort(&themes); hPrintf("
| "); hPrintf(" | ||
|---|---|---|
| "); hPrintf("", hgTrackUiName(), cartSessionVarName(), cartSessionId(cart), database, chromName, RULER_TRACK_NAME); hPrintf("%s", RULER_TRACK_LABEL); hPrintf(" | "); hTvDropDownClassVisOnlyWithLabel("ruler", rulerMode, FALSE, rulerMode ? "normalText trackVis" : "hiddenText trackVis", NULL, RULER_TRACK_LABEL); hPrintf(" | "); hPrintf("Chromosome position in bases. (Clicks here zoom in 3x)"); hPrintf(" |
| "); if (tdbIsSuperTrackChild(tdb)) /* indent members of a supertrack */ hPrintf(" "); hPrintIcons(tdb); if (track->hasUi) hPrintf("", tdb->parent ? "Part of super track: " : "Configure ", tdb->parent ? tdb->parent->shortLabel : tdb->shortLabel, hTrackUiForTrack(tdb->track), cartSessionVarName(), cartSessionId(cart), database, track->track); hPrintf(" %s", tdb->shortLabel); if (track->hasUi) hPrintf(""); hPrintf(" | "); if (tdbIsSuperTrackChild(tdb)) /* indent members of a supertrack */ hPrintf(" "); /* If track is not on this chrom print an informational message for the user. */ if (tdbIsDownloadsOnly(tdb)) // No vis display for downloadsOnly hPrintf("Downloads", hgFileUiName(),cartSessionVarName(), cartSessionId(cart), tdb->track); else if (hTrackOnChrom(track->tdb, chromName)) { if (tdbIsSuper(track->tdb)) { /* supertrack dropdown is hide/show */ superTrackDropDown(cart, track->tdb, 1); } else { /* check for option of limiting visibility to one mode */ hTvDropDownClassVisOnlyWithLabel(track->track, track->visibility, rTdbTreeCanPack(track->tdb), (track->visibility == tvHide) ? "hiddenText trackVis" : "normalText trackVis", trackDbSetting(track->tdb, "onlyVisibility"), tdb->shortLabel); } } else hPrintf("[No data-%s]", chromName); hPrintf(" | "); hPrintf("%s", tdb->longLabel); hPrintf(" |
| "); cgiDown(0.9); hPrintf(" | ||