Commits for markd
switch to files view, user index
v503_preview to v503_preview2 (2026-08-17 to 2026-08-24) v503
Show details
d3f0b85414443b18f60a04da085238a558c8cd89 Fri Aug 21 13:52:08 2026 -0700
- floretStyle.css: make the background actually apply. refs #38159
The file had never worked. Four separate faults, each enough on its own to
stop the background from showing:
- The value was a bare URL, "background: http://genome-test.soe.ucsc.edu/...",
with no url() wrapper, so the declaration was invalid and dropped.
- The host was hardcoded to genome-test, wrong on dev, beta, the RR and every
mirror. Now site-relative, and floret.jpg is at htdocs/images/floret.jpg.
- The selector was a bare BODY, specificity 0,0,1. HGStyle.css has body.cgi
and body.hgTracks rules at 0,1,1, so it lost the cascade regardless of
source order. Now body.cgi, which ties both and wins on order.
- background-image alone left HGStyle's body.hgTracks longhands in place,
repeat-x / left bottom / fixed, so the image drew as a band across the
bottom rather than tiling. Now the background shorthand.
Also scope the TH rule with :not(:empty). web.c emits <TH HEIGHT=10></TH> as a
vertical spacer in three places, webNewSectionHeaderEnd and two siblings, plus
once in cgilib/gvUi.c. Coloring every TH turned those blank cells into visible
boxes, one next to the Submit button on the configure page. On that page 2 of
the 14 TH elements are the empty spacers and 12 are real group headers, so
:not(:empty) hits exactly the ones that should be colored.
Verified with headless Chrome: background tiles, populated TH keeps its color,
empty spacer TH draws nothing.
- src/hg/htdocs/style/floretStyle.css - lines changed 10, context: html, text, full: html, text
a08ccd7dd4930bff5bcf0a32bd35ec22db71215f Sat Aug 22 06:14:41 2026 -0700
- Fix the browser.theme drop down, which has never applied a theme, and retire browser.background and browser.bgcolor from the example configs. refs #38158
themeDropDown built the menu label from the hg.conf key and posted that label
back, while setThemeFromCart looks a theme up by key, so no entry carrying a sort
prefix or an underscore could ever resolve. Broken since af6898753ba (2023)
introduced that key format and changed the menu side without the lookup side.
themeDropDown now passes the key suffix as the option value and the prettified
label as the display text, using cgiMakeDropListWithVals.
setThemeFromCart compared the generated link against "<>" instead of the config
value, so the "no theme file" marker never fired. It also let an empty link from
a missing CSS file overwrite browser.style with nothing. Both now test the right
string and leave browser.style alone when there is no theme to apply.
browser.background has not been read by any CGI since hBackgroundImage() and its
callers were removed in 2012 (8e6fcda9f58), and browser.bgcolor has never been
read at all, yet ex.hg.conf presented browser.background as a working setting.
Commented both out with a note, in ex.hg.conf and the three browserbox configs.
ex.hg.conf also documented two conflicting browser.theme formats in two places.
The comma form stopped working in 2023. Consolidated to a single block that
describes what the code actually does.
- src/browserbox/home/browser/.hg.conf - lines changed 6, context: html, text, full: html, text
- src/browserbox/root/hg.conf.offline - lines changed 6, context: html, text, full: html, text
- src/browserbox/usr/local/apache/cgi-bin/hg.conf - lines changed 6, context: html, text, full: html, text
- src/hg/hgTracks/config.c - lines changed 30, context: html, text, full: html, text
- src/product/ex.hg.conf - lines changed 30, context: html, text, full: html, text
65c950cd922b626ce3bce7de25f70e8d38237e5d Sat Aug 22 06:44:10 2026 -0700
- fixed redmine user name for markd
switch to files view, user index