c80f2909a9df53021fb01b455b122414ad73c961 braney Sun Sep 20 06:51:14 2026 -0700 move bedItemRgbTester to hg/cgilib/tests, beside the code it tests I said in the last commit that hg/cgilib had no tests directory. It does, and I should have looked rather than inferred. bedCart.c lives in hg/cgilib, so its test belongs there, and the header comment saying otherwise is fixed. Worth knowing about that directory: its test target ran nothing. annoGratorTest is commented out because it needs assemblies and tables the directory cannot assume, so `make test` there printed "tested all" and did no work -- and hg/makefile has been running it all along through TEST_EXTRA. bedItemRgbTest is now the one test it does run. refs #36212, refs #38391 diff --git src/hg/lib/tests/bedItemRgbTester.c src/hg/cgilib/tests/bedItemRgbTester.c similarity index 96% rename from src/hg/lib/tests/bedItemRgbTester.c rename to src/hg/cgilib/tests/bedItemRgbTester.c index 7bebcb50abf..ae496d43aa8 100644 --- src/hg/lib/tests/bedItemRgbTester.c +++ src/hg/cgilib/tests/bedItemRgbTester.c @@ -1,21 +1,20 @@ /* bedItemRgbTester - check which stanza wins when a track says both "itemRgb" and "color". * * bedItemRgb() decides whether a BED track draws its items in the colors the file carries or - * in the one color the stanza names. It lives in hg/cgilib/bedCart.c, and the test is here - * because hg/cgilib has no tests directory of its own; the link line below pulls in - * jkhgapcgi.a for it. + * in the one color the stanza names. It lives in hg/cgilib/bedCart.c, so the test lives + * here beside it. * * The rule has four steps and the order of the first three is the whole of #36212. An * explicit "itemRgb off" wins, then an explicit "itemRgb on" wins, and only then does the * presence of a "color" setting turn item colors off by default. Commit 88d620e6c82 folded * the first two tests together with the third, so a stanza saying both "itemRgb on" and * "color" -- which means "items from the file, labels from color" -- lost its item colors. * * Nothing about that is visible to a test that only looks at one setting at a time, which is * why the pairs below matter more than the singles: every single-setting case passed while * the bug was live. * * The last step reads hg.conf's alwaysItemRgb, so the makefile runs this twice, once with * that knob left alone and once with it off, and both answers are diffed. A mirror that * turns it off must still get item colors from a stanza that explicitly asks for them. *