9ec2018c4b216f3c3a8e846e638247d425736c03 braney Thu Sep 17 09:37:50 2026 -0700 hgTablesTest: end the caught-abort log lines with a newline, refs #38356 recordAbort's two log calls were the only ones in this file with no trailing newline in the format string. Neither verbose nor fprintf adds one, and none of the seventeen errAbort calls here end their own message with a newline either, so errCatch->message->string does not supply the missing one. Every caught abort ran into the next log line, on stderr and in the log file. The counts, the exit code and the Total: line the robot greps are unaffected. diff --git src/hg/hgTablesTest/hgTablesTest.c src/hg/hgTablesTest/hgTablesTest.c index 2f3a6bdf151..ff18efcbb52 100644 --- src/hg/hgTablesTest/hgTablesTest.c +++ src/hg/hgTablesTest/hgTablesTest.c @@ -149,34 +149,34 @@ fprintf(f, "%s ", test->info[i]); fprintf(f, "%s\n", test->status->errMessage); } static void recordAbort(char *message, char *type, char *org, char *db, char *group, char *track, char *table) /* Turn a caught errAbort into a hard error in the summary. quickSubmit records * how the page fetch went; nothing records what a test made of the page it got, * so without this an abort inside a test would vanish from the counts. */ { struct qaStatus *qs; AllocVar(qs); qs->hardError = TRUE; qs->errMessage = cloneString(message); tablesTestNew(qs, type, org, db, group, track, table); -verbose(1, "Caught abort testing %s (%s %s %s %s %s): %s", +verbose(1, "Caught abort testing %s (%s %s %s %s %s): %s\n", type, naForNull(org), naForNull(db), naForNull(group), naForNull(track), naForNull(table), naForNull(message)); -fprintf(logFile, "Caught abort testing %s (%s %s %s %s %s): %s", +fprintf(logFile, "Caught abort testing %s (%s %s %s %s %s): %s\n", type, naForNull(org), naForNull(db), naForNull(group), naForNull(track), naForNull(table), naForNull(message)); } struct htmlPage *quickSubmit(struct htmlPage *basePage, char *org, char *db, char *group, char *track, char *table, char *testName, char *button, char *buttonVal) /* Submit page and record info. Return NULL if a problem. */ { struct htmlPage *page = NULL; // don't get ahead of the botDelay sleep1000(5000); verbose(2, "quickSubmit(%p, %s, %s, %s, %s, %s, %s, %s, %s)\n",