3212c75cbe810013f1c3a0993934b0b70f6d7d2d
braney
  Wed Sep 16 08:35:38 2026 -0700
perfNightly: build hg/cgilib and optimalLeaf too, refs #37547

The build step ran topLibs plus hg/lib, which leaves jkhgapcgi.a and
optimalLeaf.a alone.  hgTracks links both (MYLIBS in hg/hgTracks/makefile)
and has no rule to build them, so make used whatever was already on disk.
A change under hg/cgilib or optimalLeaf would be pulled in by --update and
then silently not relinked into today's binary, which is exactly the kind
of regression this job exists to catch.  'make libs' is topLibs + hgLib +
optLib and covers all four archives.

diff --git src/hg/utils/perfNightly/nightly.sh src/hg/utils/perfNightly/nightly.sh
index 609fe698c51..017f22bb2c0 100755
--- src/hg/utils/perfNightly/nightly.sh
+++ src/hg/utils/perfNightly/nightly.sh
@@ -111,31 +111,31 @@
     ahead=$(git -C "$HERE" rev-list --oneline FETCH_HEAD..HEAD 2>&1)
     [ -z "$ahead" ] || bail "--update will not reset $HERE: it holds commits that are not on origin/master.
 
 $ahead"
     git -C "$HERE" reset -q --hard FETCH_HEAD 2>&1 || bail "--update could not move $HERE to FETCH_HEAD."
     export PERF_NIGHTLY_UPDATED=1
     exec "$0" "$@"
 fi
 
 COMMIT=$(git -C "$HERE" rev-parse --short HEAD 2>/dev/null)
 
 # ---------------------------------------------------------------- build
 
 BUILDLOG=$LOGDIR/.build.$STAMP
 {
-    make -C "$SRC" -j8 topLibs && make -C "$SRC/hg/lib" -j8 && make -C "$SRC/hg/hgTracks" -j8 compile
+    make -C "$SRC" -j8 libs && make -C "$SRC/hg/hgTracks" -j8 compile
 } > "$BUILDLOG" 2>&1
 if [ $? -ne 0 ] || [ ! -x "$SRC/hg/hgTracks/hgTracks" ]; then
     bail "The build of master failed at $COMMIT.  That is news about the tree, not about this job.
 
 $(tail -40 "$BUILDLOG")"
 fi
 
 mkdir -p "$ROOT/today"
 cp -f "$SRC/hg/hgTracks/hgTracks" "$SRC/hg/hgTracks/hgRenderTracks" "$ROOT/today/" || bail "could not stage today's binaries in $ROOT/today"
 echo "$COMMIT $(date +%F_%H%M)" > "$ROOT/today/STAMP"
 rm -f "$BUILDLOG"
 
 # ---------------------------------------------------------------- first run seeds
 
 if [ ! -x "$REF/hgTracks" ]; then