eccdddfb22cf35d4e5698f72a4b12707aa43b349 braney Sun Sep 20 14:27:27 2026 -0700 testRegistry: check the docent column's "-" as well as its names The docent column says which browser test watches the same ticket, and a named script was already checked: it has to exist and has to belong to that ticket. A "-" was checked by nothing, and that was the wrong half to leave out. `unwatched` -- the list of tickets where nothing anywhere would go red if the bug came back -- is built entirely out of those "-" values. They were entered by hand, by reading the docent directory once, so a script written the next day left the ticket sitting on that queue with nothing to notice. For the four tickets that are on it because their code lives inside a CGI, somebody writing the docent script is the expected outcome, which made it the likeliest kind of row to go stale. So a row claiming no docent script is now checked against the tree the same way a named one is: if rm<ticket>.*docent.yaml turns up, the check fails and asks for the row to be filled in. The failure is somebody doing the right thing and the table not having heard about it. Watched to fail and then pass: blanking the docent column of #36212, whose script is in the tree, turns the real table red with the name of the script it found. refs #38391 diff --git src/utils/testRegistry/tests/input/bad.tsv src/utils/testRegistry/tests/input/bad.tsv index 7caed7d444e..9c87b86775e 100644 --- src/utils/testRegistry/tests/input/bad.tsv +++ src/utils/testRegistry/tests/input/bad.tsv @@ -1,16 +1,17 @@ # Every complaint check can make, one per row, so a change to check that stops making one # of them shows up as a diff rather than as silence. #ticket release test docent why evidence note 37263 504 lib/tests/pathSimplifyTest.c - library assertion-only fine 37263 504 lib/tests/pathSimplifyTest.c - library assertion-only the same row twice 38000 504 lib/tests/noSuchTest.c - library assertion-only the file is not in the tree 38001 v504 lib/tests/pathSimplifyTest.c - library assertion-only the release column carries the v 38002 504 lib/tests/pathSimplifyTest.c - library watched-it no such evidence level 38003 504 lib/tests/pathSimplifyTest.c - slow assertion-only no such reason 38004 504 lib/tests/pathSimplifyTest.c - library assertion-only 38005 504 - - perf assertion-only no test, but a claim of evidence anyway 38006 504 lib/tests/pathSimplifyTest.c - library assertion-only this one says covered 38006 504 - - library - while this one says waiting 38000 504 lib/tests/pathSimplifyTest.c - library assertion-only out of order, so the sort check fires 38007 504 lib/tests/pathSimplifyTest.c rm38007.docent.yaml library assertion-only names a docent script that is not there 38008 504 lib/tests/pathSimplifyTest.c rm38303.docent.yaml library assertion-only names another ticket's docent script +36212 504 lib/tests/pathSimplifyTest.c - library assertion-only its docent script is in the tree but this row says there is none