cb99f0b11bdeee5dfa76064d38b6410da0f4a709
max
  Thu Sep 10 00:55:21 2026 -0700
Centralize CGI Content-Type printing in one cgiPrintContentType() helper

Around 90 places across the tree hand-rolled the CGI response header, each
with its own spelling: "Content-Type:" or "Content-type:", \n or \r\n, and
the terminating blank line written as part of the same string, as a separate
puts("\n") (which emits two newlines, so a stray blank line led the body) or
as printf("\r\n\r\n") (two blank lines).  A handful forgot the terminator
entirely and relied on a following header to supply it.

cgiPrintContentType() in lib/cheapcgi.c now writes the Content-Type line and
the blank line that ends the header.  Header lines are not ordered, so the
callers that also send Status, Set-Cookie, Content-Disposition, Content-Length
or X-Sendfile write those first and call this last to close the header; that
keeps it to a single helper rather than a print-the-line / end-the-header pair
that a caller can half-use.  cart.c's existing httpHeaders list already worked
this way.

Only the CGI response path is touched.  The dyStringPrintf("Content-type: ...")
calls that build outgoing HTTP *requests* (genomeSpace, oauthLogin, eapMetaSync,
edwWebAuthLogin, ga4ghToBed) are unrelated and left alone.

Also fills out the apiKey error message in botDelay.c to say where to create a
key and that keys are server-specific.

No behavior change on the wire beyond dropping those stray blank lines and
adding the missing newline after Retry-After.

diff --git src/hg/cgilib/api.c src/hg/cgilib/api.c
index a94c48768c2..447d1b770f3 100644
--- src/hg/cgilib/api.c
+++ src/hg/cgilib/api.c
@@ -1,26 +1,26 @@
 /* Utility functions for web API programs */
 
 /* Copyright (C) 2014 The Regents of the University of California 
  * See kent/LICENSE or http://genome.ucsc.edu/license/ for licensing information. */
 
 #include "common.h"
 #include "cheapcgi.h"
 #include "api.h"
 
 void apiOut(char *text, char *jsonp)
 /* Output content header and text to stdout */
 {
 // It's debatable whether the type should be text/plain, text/javascript or application/javascript;
 // text/javascript works with all our supported browsers, so we are using that one.
-puts("Content-Type:text/javascript\n");
+cgiPrintContentType("text/javascript");
 
 if (jsonp && isValidJsonpCallback(jsonp))
     {
     printf("%s(%s)", jsonp, text);
     }
 else
     {
     // No callback, or an invalid callback name: emit the bare (unpadded) JSON.
     puts(text);
     }
 }