0855c081b7178591b4d1548ec822ce4ea329ec37 braney Mon Sep 21 14:29:21 2026 -0700 tests: stop a comment dropping four testers out of hg/lib/tests all: The all: target listed annoGratorTester on a commented line in the middle of the list. The line above it ends in a backslash, so make joins the two lines and the "#" then comments out the rest of the joined line. The continuations carry that comment to the end, so binTest, customTrackTester, hgvsTester and sqlCheck were never built by "make all". True since b30a73b6c5f in 2021. make test still built all four, because customTrackTest:, hgvsTest: and binTest: each name their binary as a prerequisite. Only a bare "make all" in this directory skipped them. Moved the commented line below the list. All ten testers now build and make test still passes. refs #38391 diff --git src/hg/lib/tests/makefile src/hg/lib/tests/makefile index 141d5be717b..d0fad04ad10 100644 --- src/hg/lib/tests/makefile +++ src/hg/lib/tests/makefile @@ -1,34 +1,36 @@ kentSrc = ../../.. include ../../../inc/common.mk L += ${MYSQLLIBS} -lm MYLIBDIR = ../../../lib/${MACHTYPE} MYLIBS = ${MYLIBDIR}/jkhgap.a ${MYLIBDIR}/jkweb.a BIN_DIR = bin/${MACHTYPE} all: ${BIN_DIR}/genePredTester \ ${BIN_DIR}/trashDirTester \ ${BIN_DIR}/mallocTopPadTester \ ${BIN_DIR}/pslReaderTester \ ${BIN_DIR}/quickLiftTester \ ${BIN_DIR}/sessionDataTester \ -# ${BIN_DIR}/annoGratorTester \ ${BIN_DIR}/binTest \ ${BIN_DIR}/customTrackTester \ ${BIN_DIR}/hgvsTester \ ${BIN_DIR}/sqlCheck +# annoGratorTester is left out, like the annoGratorTest target below. A commented +# line inside the list above would comment out every entry after it, because the +# backslash on the line before joins them into one line. ${BIN_DIR}/%: %.c ${MYLIBS} @${MKDIR} ${BIN_DIR} ${CC} ${CC_PROG_OPTS} -o $@ $*.c ${MYLIBS} $L #test: binTest spDbTest hdbTest genePredTest pslReaderTest annoGratorTest customTrackTest hgvsTest test: binTest quickLiftTest sessionDataTest trashDirTest mallocTopPadTest \ hVarSubstHtmlTest dataVersionPathTest genarkLiftOverTest \ snapshotTypeTest sessionDirTest geoMirrorSelfTest asForDbTest spDbTest hdbTest genePredTest pslReaderTest customTrackTest hgvsTest rm -r output echo tested all mkdirs: @${MKDIR} output ${BIN_DIR}