1f5a5224a1eae411c945406c4e1adb2d5b18ebcb braney Tue Sep 22 10:46:35 2026 -0700 genarkLiftOverTest: set genarkLiftOver in the test's own conf, refs #38328 genarkLiftOverDbs returns NULL before it looks at anything when genarkLiftOver is not set, so the test read as "0 back" on every line and went red on an hg.conf that does not have the option. The build account's conf does not have it. The test now writes its own conf and sets the option, the same way geoMirrorSelfTest sets browser.node. diff --git src/hg/lib/tests/makefile src/hg/lib/tests/makefile index d0fad04ad10..ad760a8ae3a 100644 --- src/hg/lib/tests/makefile +++ src/hg/lib/tests/makefile @@ -107,33 +107,38 @@ echo "mallocTopPad=33554432" >> output/topPadOn.conf HGDB_CONF=output/topPadOff.conf ${BIN_DIR}/mallocTopPadTester > output/mallocTopPadTest HGDB_CONF=output/topPadOn.conf ${BIN_DIR}/mallocTopPadTester >> output/mallocTopPadTest diff expected/mallocTopPadTest output/mallocTopPadTest hVarSubstHtmlTest: mkdirs ${CC} ${CC_PROG_OPTS} -o ${BIN_DIR}/hVarSubstHtmlTester hVarSubstHtmlTester.c ${MYLIBS} $L ${BIN_DIR}/hVarSubstHtmlTester > output/hVarSubstHtmlTest diff expected/hVarSubstHtmlTest output/hVarSubstHtmlTest dataVersionPathTest: mkdirs ${CC} ${CC_PROG_OPTS} -o ${BIN_DIR}/dataVersionPathTester dataVersionPathTester.c ${MYLIBS} $L ${BIN_DIR}/dataVersionPathTester > output/dataVersionPathTest diff expected/dataVersionPathTest output/dataVersionPathTest +# genarkLiftOver is set in the conf rather than assumed. genarkLiftOverDbs returns nothing +# at all when the option is off, so a developer's own hg.conf without it turns every line of +# the expected output into "0 back" and the test goes red for a reason that is not the code. genarkLiftOverTest: mkdirs ${CC} ${CC_PROG_OPTS} -o ${BIN_DIR}/genarkLiftOverTester genarkLiftOverTester.c ${MYLIBS} $L - ${BIN_DIR}/genarkLiftOverTester > output/genarkLiftOverTest + echo "include ${HOME}/.hg.conf" > output/genarkLiftOver.conf + echo "genarkLiftOver=on" >> output/genarkLiftOver.conf + HGDB_CONF=output/genarkLiftOver.conf ${BIN_DIR}/genarkLiftOverTester > output/genarkLiftOverTest diff expected/genarkLiftOverTest output/genarkLiftOverTest snapshotTypeTest: mkdirs ${CC} ${CC_PROG_OPTS} -o ${BIN_DIR}/snapshotTypeTester snapshotTypeTester.c ${MYLIBS} $L ${BIN_DIR}/snapshotTypeTester > output/snapshotTypeTest diff expected/snapshotTypeTest output/snapshotTypeTest sessionDirTest: mkdirs ${CC} ${CC_PROG_OPTS} -o ${BIN_DIR}/sessionDirTester sessionDirTester.c ${MYLIBS} $L ${BIN_DIR}/sessionDirTester > output/sessionDirTest diff expected/sessionDirTest output/sessionDirTest # browser.node is set in the conf rather than assumed, since a developer's own hg.conf need # not have one. geoMirrorSelfTest: mkdirs