752e20a9a1dc08793c5b529bbeac4ce5836a6be4 braney Fri Sep 4 17:13:55 2026 -0700 hgc: stop five details-page handlers from aborting over a missing piece. chromSeqFileExists() opened its connection with sqlConnect() and only then asked whether the database existed, so it aborted before it could answer. The otherDb of a chain or net track is often not a local database at all -- a GenArk hub assembly, or one long retired -- so use sqlMayConnect() and return FALSE. This is 112 of the failures the TrackCheck robot reports, most of them hg38 net tracks against HPRC assemblies. Also moved the disconnect out of the if, where it leaked a connection whenever a database had no chromInfo table, and dropped the now-redundant sqlDatabaseExists() call, which was itself a second connection. mgcCloneInfoLoad() aborted when a clone carried no MGC: id in hgFixed.mrnaClone. Nothing on the page reads that field, and a clone can legitimately have only an IMAGE: id, so the check went away rather than the page. hDbOrganism() aborted for an assembly that has left dbDb but is still named by a maf component, which hg16.evofold does via mm3; it now falls back on the database name. The pgSnp SIFT and Polyphen prediction tables are loaded separately from the tracks that name them, so a machine can have the track and not the table, as hgwbeta and the RR do for hg18. Check with hTableExists first and say the predictions are unavailable instead of letting the query take the page down. Same treatment for the RNA fold diagram: a non-zero ghostscript exit now drops only the diagram and keeps the rest of the page, including the PseudoViewer link. Two of these report an unavailable piece through warn(), which still marks the page for the robot. That is deliberate -- the missing hg18 tables and the RNA fold diagram are real defects, and the log should keep naming them until they are fixed. On the RNA fold diagram in particular: RNAplot truncates the sequence id it is given to 42 characters, and the trash path we build is already 41, so it has never written the file ghostscript is asked to convert. That is worth its own fix. refs #37424 diff --git src/hg/hgc/mgcClick.c src/hg/hgc/mgcClick.c index 92498bc785f..9cc659ef5f9 100644 --- src/hg/hgc/mgcClick.c +++ src/hg/hgc/mgcClick.c @@ -291,34 +291,34 @@ freeMem(ci->keyword); freeMem(ci->refSeqAccv); freeMem(ci->refSeqSum); geneSimilaritiesFree(&ci->refSeqs); freeMem(ci); *ciPtr = NULL; } } static struct cloneInfo *mgcCloneInfoLoad(struct sqlConnection *conn, char *acc, int start) /* Load MGC clone information */ { struct cloneInfo *ci = cloneInfoLoad(conn, acc, start, "mgcFullMrna", "mgcGenes"); ci->isMgc = TRUE; -if (ci->mgcId == 0) - errAbort("no MGC:nnnn entry in mrnaClone table for MGC clone %s", acc); -if (ci->imageId == 0) - errAbort("no IMAGE:nnnn entry in mrnaClone table for MGC clone %s", acc); +/* mgcId and imageId are not used by the rest of the page, and a clone in mgcFullMrna + * can legitimately carry only one of the two ids in hgFixed.mrnaClone (BC111925 is + * named IMAGE:40080739 and has no MGC: component), so a missing id is not worth + * losing the details page over. refs #37424 */ return ci; } static struct cloneInfo *orfeomeCloneInfoLoad(struct sqlConnection *conn, char *acc, int start) /* Load ORFeome clone information */ { struct cloneInfo *ci = cloneInfoLoad(conn, acc, start, "orfeomeMrna", "orfeomeGenes"); ci->isMgc = FALSE; return ci; } static void prCellLabelVal(char *label, char *val) /* print label and value as adjacent cells */