e497eccfb431be6af38d22c5bc2bb0e745c89b2d braney Sat Sep 5 09:22:17 2026 -0700 docent: eight more regression scripts, one per fixed bug rm35580 "Show placed on its chromosome" errored on the window rm36061 DECIPHER SNVs details missing after a quickLift rm36335 a quickLifted GIAB item click printed a garbled "can't port" rm36340 a search-result click carried the source coordinate rm37491 hgConvert named subtracks the user never showed as not liftable rm37562 a stale lastPosition banner on the lifted search-results page rm37615 a quickLifted bigBed tooltip reported pre-lift coordinates rm37785 a squishyPack track stole a neighbouring track's center label Each asserts the behavior its ticket says is correct, on genome-test, and names in noText:/noUrl: the exact string the buggy build produced rather than a generic "Error". Where the last page has no track image the noText: is paired with a positive text: or url: check, because a bare noText: passes just as happily on a blank page or an early error. Four things found writing these, all of them recorded in the scripts: A ticket's stated position and its stated item can disagree. #36061 says to go to chr7:156,982,676-156,996,015 and click item 517898; that item is at chr7:155,803,191, and decipherSnvs draws nothing at all in the ticket's window. hideKids cannot express "the user deselected this subtrack". It writes a =hide cart variable, and isSubtrackVisible() (hg/lib/trackHub.c) begins with overrideComposite = (NULL != cartOptionalString(cart, tdb->track)) and then forces enabled = TRUE, so the sibling counts as visible to hgConvert and lands back in the "failed to lift" warning. A first rm37491 failed on exactly that and looked like the bug being back. A deselected subtrack is _sel=0 with no visibility variable, which is what hgTrackUi's checkbox writes and what the goto: in that script sets. #37615's fix is not the one the plan for this suite described. The first commit appended a note saying the coordinates came from the source assembly; the second replaced it with the real fix, which puts the TARGET coordinates in the tooltip. A test for the note would fail. decipherSnvs (SNVs) and decipher (CNVs) are two different members of the superTrack decipherContainer, and the row that turns up when the SNVs track draws nothing is the CNVs one, which reads like the same track under a shorter id. refs #38252 diff --git src/hg/utils/docent/tests/regress/rm37491.docent.yaml src/hg/utils/docent/tests/regress/rm37491.docent.yaml new file mode 100644 index 00000000000..aca50450f2e --- /dev/null +++ src/hg/utils/docent/tests/regress/rm37491.docent.yaml @@ -0,0 +1,60 @@ +# #37491 -- hgConvert's QuickLift warning named composite subtracks the user never showed. +# +# validateTdbChildren() in hg/lib/trackHub.c walked EVERY subtrack of a composite and put +# any non-liftable type into the user-facing list under +# +# Some of your tracks failed to lift because the type is not supported by QuickLift. +# +# even subtracks that were switched off. Fixed in c4e77d5b638; the code now reads +# `validateOneTdb(db, tdb, visible ? badList : NULL)`, so a subtrack that is not visible is +# still lifted alongside its visible siblings but is no longer complained about. +# +# Platinum Genomes is the composite to use: all three of its subtracks are type vcfTabix, +# which QuickLift does not support, so with exactly one of them showing the warning has +# exactly one row. Before the fix all three were listed however few were on. +# +# THE TRAP, and it cost a run. `track: {platinumGenomes: hideKids, platinumNA12878: pack}` +# does not express "the user deselected the other two". hideKids writes a `=hide` +# cart variable for each sibling, and isSubtrackVisible() (hg/lib/trackHub.c:1847) begins +# +# boolean overrideComposite = (NULL != cartOptionalString(cart, tdb->track)); +# ... +# if (overrideComposite) enabled = TRUE; +# +# so the mere presence of that variable makes the sibling count as visible and it lands in +# the warning again -- a first version of this test failed on `noText: "NA12877"` and +# looked exactly like the bug being back. What a deselected subtrack really looks like is +# `_sel=0` and NO visibility variable at all, which is what the checkbox on +# hgTrackUi writes. There is no verb for that, so the state is set with the goto: escape +# hatch. +# +# mane is turned on as well so the lift has something it CAN carry. +target: genome-test +db: hg38 +position: chr17:43044295-43125364 +reset: true +fast: true +steps: + - go: chr17:43044295-43125364 + - hide: all + - goto: "/cgi-bin/hgTracks?db=hg38&position=chr17:43044295-43125364&pix=1100&mane=pack&platinumGenomes=pack&platinumNA12878_sel=1&platinumNA12877_sel=0&platinumHybrid_sel=0" + + # One of the three drawn and the other two not. This is the state the warning is read + # against, so it is asserted rather than assumed. + - expect: + rows: [mane, platinumNA12878] + noRows: [platinumNA12877, platinumHybrid] + noText: "Warning/Error" + + - convert: {to: hs1, quicklift: true} + + # The Convert RESULT page, before the click through to the lifted view. No other verb + # reaches this page, and it is the only place the warning appears. + # + # Both halves matter. text: says the warning really was printed, so the noText: below is + # not passing on a page that has no warning at all -- which is what a lift with nothing + # unsupported in it would produce. + - expect: + text: "Some of your tracks failed to lift" + noText: "NA12877" + - expect: {text: "NA12878"}