571aecdf42c832e61ee921e977589ca386467d13 max Fri Sep 4 12:24:17 2026 -0700 hubCheck: report a bigDataUrl that cannot be opened instead of dropping the track, refs #38260 hubCheckGenome() called trackDbPolishAfterLinkup(), whose pruneEmpties() step hands each track to addTrackIfDataAccessible(), which frees any track whose data cannot be reached. That is right for the browser, which should degrade gracefully rather than draw a broken track, and wrong for hubCheck, whose main job is to say that the file is unreachable. The track was gone before the file check ran, so hubCheck printed nothing and exited 0: cd hubCheck/tests/input sed 's|test6field.bb|noSuchFile.bb|' fieldCountMismatch.txt > tmp.txt hubCheck tmp.txt # only the descriptionUrl warning, missing file not mentioned Split the non-pruning part of trackDbPolishAfterLinkup() into trackDbPolishAfterLinkupKeepAll() and call that from hubCheck. Every other caller still goes through trackDbPolishAfterLinkup() and still prunes, so browser behaviour is unchanged. Added a tests/ case whose bigDataUrl does not exist. Before this change it produced no output and exit 0; now it reports "Couldn't open input/relPath/data/noSuchFile.bb". Of the existing tests, only badType changes, and it gains a real error that the prune had been hiding: 'unrecognized type "wig" for track "invalidType"'. badType was already failing before this commit and still is, for an unrelated reason: seven tests carry expected output with per-track "missing description page" warnings that no longer appear, because those hubs point at remote URLs that no longer resolve and hubCheckTrack aborts at the file check before reaching the description check. That is stale test data, not addressed here. diff --git src/hg/utils/hubCheck/tests/input/relPath/missingFile.txt src/hg/utils/hubCheck/tests/input/relPath/missingFile.txt new file mode 100644 index 00000000000..213b0802a07 --- /dev/null +++ src/hg/utils/hubCheck/tests/input/relPath/missingFile.txt @@ -0,0 +1,18 @@ +hub relPathMissing +shortLabel relPathMissing +longLabel a bigDataUrl that does not exist must be reported, not dropped +email braney@soe.ucsc.edu +descriptionUrl hubDescription.html +useOneFile on + +genome mm10 + +# A track whose data file is genuinely absent. hubCheck used to hand this list to +# trackDbPolishAfterLinkup(), whose prune step dropped any track it could not open, so +# the one thing hubCheck most needs to report was the one thing it stayed quiet about. +track relPathMissingTrack +type bigBed 6 +bigDataUrl data/noSuchFile.bb +shortLabel relPathMissingTrack +longLabel bigDataUrl pointing at a file that is not there +visibility dense