7aba31f14aed7f2620e4746b54f9569a5c93e1ad
braney
Sat Sep 12 15:07:34 2026 -0700
docent: ten regression tests for quickLift, on hgTracks and on hgc, refs #38252
Fourteen scripts here already lift something -- they are the ones that call
`convert: {quicklift: true}` -- so these take the parts of the lift that had no
test. Five read the lifted image and five read a details page:
rm38032 the target keeps the source's track order. First use of `ordered:`,
which was added to expect: for this bug
rm38042 a ClinVar CNV running past the chains quickLift loads is clipped
rather than dropped, so the spanned-item merge still has it
rm37646 a lolly composite subtrack lifts, and its map boxes still carry its
own track name -- the string the stale pop pointer clobbered
rm36048 the spanned-item merge still works on a lifted DECIPHER track
rm37815 "Hide all default tracks on the target" hides all six of hs1's own
tracks and keeps the lifted one
rm36059 a lifted GENCODE Versions item gives the real details page, in
destination coordinates, with no "Can't start query"
rm36370 a lifted knownGene click renders GeneReviews and Methods, the two
sections the ticket says were missing
rm36125 a lifted RefSeq item's page, and its Predicted Protein link
returning SHH's peptide instead of a blank page
rm36942 the Alignment Differences description, reached from a difference
item: the four colors and the figure
rm38146 the same page with a GenArk assembly as the SOURCE, down to the base
alignment that reads query bases out of a two bit file
All ten are assertion-only: every fix shipped long ago. make test is 57 of 57
green in 10m18s, up from 7m34s -- each script costs a convert, about 17 seconds,
because no URL builds a quickLift hub.
README.txt gains what the batch cost. A lifted row and map box carry a per-run
hub_<n>_ prefix, so rows: matches by suffix and a has: selector must use a
substring. Never assert a count an otto reload can move: rm38042 and rm36048
both read the merged-item box and leave its count (45 for ClinVar today) to a
comment. And a details page prints the track's own labels whether or not it
worked, so each hgc assertion names something only the fixed page has.
Three candidates were rejected: #38033's "(N items could not be lifted)" label
is only in the drawn image and the page JSON, where no expect: check reaches it;
#37970 needs a broadPeak track and hg38 has none; #37974's center-label drag is
pixels.
diff --git src/hg/utils/docent/tests/regress/rm36370.docent.yaml src/hg/utils/docent/tests/regress/rm36370.docent.yaml
new file mode 100644
index 00000000000..1a752c1267c
--- /dev/null
+++ src/hg/utils/docent/tests/regress/rm36370.docent.yaml
@@ -0,0 +1,41 @@
+# #36370 -- two sections were missing from the hgGene details page of a quickLifted
+# knownGene item: "GeneReviews for This Gene" and "Methods, Credits, and Use Restrictions".
+# Their links in the page index did nothing, and the sections themselves were not on the
+# page. Gerardo's case is the SHH item after a QuickLift from hg38 to hs1.
+#
+# a378dddb8d9 and 3670b9f2a58 render all sections and the Methods page for QuickLift
+# knownGene clicks; dec7900a42f fixed a crash in genePred.c when flipping strands with no
+# exon frames, found in the same work.
+#
+# The assertion is on the two section headings themselves, not on the page index, because
+# the index links were present in the ticket's own screenshots and did nothing -- a test
+# that asked for the link text would have passed on the build the ticket was filed
+# against.
+#
+# This is the knownGene page, which hgGene renders. rm36059 is the GENCODE Versions
+# archive track, which hgc renders through doGencodeGene, and the two pages are different
+# enough that neither covers the other: the archive page has no GeneReviews or Methods
+# section at all.
+proof:
+ - "assertion-only 2026-09-12 -- written from the ticket after the fix shipped"
+
+target: genome-test
+db: hg38
+position: chr7:155799529-155812871
+reset: true
+fast: true
+steps:
+ - go: chr7:155799529-155812871
+ - hide: all
+ - track: {knownGene: pack}
+ - expect: {rows: [knownGene], noText: "Warning/Error"}
+
+ - convert: {to: hs1, quicklift: true, hideDefaults: true}
+ - open: lift
+ - expect: {rows: [knownGene], noText: "Warning/Error"}
+
+ - click: {track: knownGene, item: "ENST00000297261.7"}
+ - expect:
+ text: "GeneReviews for This Gene"
+ noText: "Warning/Error"
+ - expect: {text: "Methods, Credits, and Use Restrictions"}