4697bbddd881c72cccb85b9ff0aacd769396b9d0 braney Thu Sep 10 07:34:35 2026 -0700 docent: record what evidence each regression test has, and count it A regression test written after the fix asserts the right answer, but nobody has watched it fail for the reason it exists, and a loose assertion in that state is indistinguishable from no test at all. Four of the 37 scripts here have actually been watched to flip. That was recorded only as prose in each script's header, so answering "how many of these are real regression tests" meant a grep and a read, and the number could not be quoted. Every script now carries a top-level `proof:` key, one quoted line per piece of evidence, `<level> <YYYY-MM-DD> -- <what was seen>`. docent.js reads only the keys it names off the parsed document, so this costs a run nothing. tests/proof.js reads them and tallies, wired up as `make proof` in the shared docentTest.mk. It exits 1 on a malformed line, an unknown level, or a line left unquoted -- that last one because nearly every note names a ticket and a bare # in an unquoted YAML scalar silently truncates the sentence at the ticket number, which is how the first pass of this change lost half its text. The levels, weakest first: assertion-only, xfail, sandbox-ab, server-flip, caught-regression. Today that reads 31 / 2 / 0 / 3 / 1. nightly.sh now records the flips it finds. An xfail that PASSES is the best evidence this suite produces -- the same server, the same fixtures, the same script, one real build apart -- and until now it arrived as a red mail and was thrown away with the log 60 days later. It is appended to /hive/users/braney/docentNightly/flips.log, one line per script ever, outside the checkout because --update resets the tree. The mail says what to do with it. The three flips that already happened (rm38272 2026-09-06, rm36212 2026-09-09, rm38310 2026-09-10) were recovered from the old logs and seeded there by hand. Full suite run after the change: 37 scripts, all ok. refs #38252 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> diff --git src/hg/utils/docent/tests/regress/rm36798.docent.yaml src/hg/utils/docent/tests/regress/rm36798.docent.yaml index 01157cc5c3e..caa1a548851 100644 --- src/hg/utils/docent/tests/regress/rm36798.docent.yaml +++ src/hg/utils/docent/tests/regress/rm36798.docent.yaml @@ -1,27 +1,30 @@ # #36798 -- the two OMIM tracks disappeared from a session after a configure submit. # # A user reported it against a saved session, and the ticket's steps are: load the # session, open Configure, set text size to 10, submit, and the two OMIM tracks are gone. # Any configuration change triggered it, not just the font. # # The ticket's session is /s/Lou/omimIssue.3 on the RR, which is in hgcentral and cannot # be loaded from genome-test. Built here instead: the session's only relevant contribution # is that the two OMIM tracks were showing. # # A configure submit is a cart write, and textSize is the cart variable it writes, so a # goto: carrying it reaches the same state as the form. Doing it through the Configure # page would test the form rather than the bug. +proof: + - "assertion-only 2026-09-04 -- written from the ticket after the fix had shipped" + target: genome-test db: hg38 position: chr17:43044295-43125364 reset: true fast: true steps: - go: chr17:43044295-43125364 - hide: all - track: {omimContainer: show, omimGene2: pack, omimAvSnp: pack} - expect: {rows: [omimGene2, omimAvSnp], noText: "Warning/Error"} # The configure change that made them vanish. - goto: "/cgi-bin/hgTracks?db=hg38&textSize=10&pix=1100" - expect: {rows: [omimGene2, omimAvSnp], noText: "Warning/Error"}