4697bbddd881c72cccb85b9ff0aacd769396b9d0 braney Thu Sep 10 07:34:35 2026 -0700 docent: record what evidence each regression test has, and count it A regression test written after the fix asserts the right answer, but nobody has watched it fail for the reason it exists, and a loose assertion in that state is indistinguishable from no test at all. Four of the 37 scripts here have actually been watched to flip. That was recorded only as prose in each script's header, so answering "how many of these are real regression tests" meant a grep and a read, and the number could not be quoted. Every script now carries a top-level `proof:` key, one quoted line per piece of evidence, ` -- `. docent.js reads only the keys it names off the parsed document, so this costs a run nothing. tests/proof.js reads them and tallies, wired up as `make proof` in the shared docentTest.mk. It exits 1 on a malformed line, an unknown level, or a line left unquoted -- that last one because nearly every note names a ticket and a bare # in an unquoted YAML scalar silently truncates the sentence at the ticket number, which is how the first pass of this change lost half its text. The levels, weakest first: assertion-only, xfail, sandbox-ab, server-flip, caught-regression. Today that reads 31 / 2 / 0 / 3 / 1. nightly.sh now records the flips it finds. An xfail that PASSES is the best evidence this suite produces -- the same server, the same fixtures, the same script, one real build apart -- and until now it arrived as a red mail and was thrown away with the log 60 days later. It is appended to /hive/users/braney/docentNightly/flips.log, one line per script ever, outside the checkout because --update resets the tree. The mail says what to do with it. The three flips that already happened (rm38272 2026-09-06, rm36212 2026-09-09, rm38310 2026-09-10) were recovered from the old logs and seeded there by hand. Full suite run after the change: 37 scripts, all ok. refs #38252 Co-Authored-By: Claude Opus 5 (1M context) diff --git src/hg/utils/docent/tests/regress/rm36888.xfail.docent.yaml src/hg/utils/docent/tests/regress/rm36888.xfail.docent.yaml index 16dcdc0f044..2a2f51dff89 100644 --- src/hg/utils/docent/tests/regress/rm36888.xfail.docent.yaml +++ src/hg/utils/docent/tests/regress/rm36888.xfail.docent.yaml @@ -41,31 +41,33 @@ # WHY THE NOTE IS CHECKED WITH has: AND WHY THE SELECTOR IS SPELLED TWICE. # labelTrackAsDensityTooManyItems (hg/hgTracks/hgTracks.c) appends the note to longLabel, # and hgTracks draws longLabel into the center-label IMAGE, so innerText never carries it # and text: is blind to it. The one textual copy is on the track's own control link. In # the SOURCE that is title=; in the live DOM it usually is not, because addMouseover() in # hg/js/utils.js empties title= and moves the text to mouseovertext= so the browser can # draw its own tooltip. That rewrite is gated on the showMouseovers hg.conf setting, so # the selector matches either spelling rather than depending on a flag that has nothing # to do with this bug. data-track is named so another track's note cannot satisfy it. # Two links carry the long label and only one of them gets the note, which is why the # check is "at least one matches" and not a count. # # The hub declares `visibility pack` itself, so there is no `hide: all` and no `track:` # step here: a track inside an attached hub carries a hub__ prefix that differs every # run and cannot be named in a cart variable. -# +proof: + - "xfail 2026-09-09 -- red on every server; bigMethylMethods installs no loadSummary, and the one-liner that fixes it is not committed" + target: genome-test reset: true fast: true db: hg38 pix: 1100 steps: - hub: {url: "https://hgwdev.gi.ucsc.edu/~braney/docentFixtures/bigMethyl36888/hub.txt", db: hg38, position: "chr1:1075000-1075100"} # Control. 400 items is well under the limit, so the items are drawn one by one. This # step is what separates "the bug is back" from "the hub went away" -- without it the # xfail below would be satisfied by a fixture that had simply stopped resolving, and an # xfail cannot tell those apart on its own. noHas: pins the other half: the note belongs # only to a window that overflowed. - expect: rows: [ruler, rm36888Methyl]