31dd19d6395d10ee6632bb2afcf1947f33eff3dd braney Sat Sep 12 16:03:40 2026 -0700 docent: ten regression tests for hgTrackUi, refs #38252 Four scripts here already touched hgTrackUi in passing (rm37389, rm37489, rm38126, rm38272). These are about the page itself: the superTrack configuration page, composite and subtrack configuration, filters, the color override, the parent link, and two bad-input paths. rm20460 the color override is offered on a genePred track and not on a chain track, which is the type restriction 6d78a8e2d72 added rm32263 a composite child's page names its container, and the link reaches the container's own configuration page rm34651 the density-graph options div is densGraphOptions and the old shared id is gone rm35906 Clear filters survives a submit: the cart comes back on All, which is what the button only appeared to do before rm36484 the filterComposite select has no stray
inside it rm36668 both the rearrangement and density-graph checkboxes on, submitted together, does not crash hgTracks rm36917 the superTrack page's Hide all / Show all / Apply to all controls, and Show all leaving no child hidden rm37130 under noParentConfig both filters are on the jaspar child page and neither is on the parent rm37282 Hide all greys the superTrack's own dropdown, and a child's Hide does not force the container back to show rm37743 a dup_1_refGene request with nothing in the cart errAborts with a message naming it, instead of taking a SIGSEGV All ten are assertion-only. make test is 67 of 67 green: the suite went from 57 scripts to 67 for 14 extra seconds, 10m32s in total, because hgTrackUi draws no image and most of these never leave it. README.txt gains the four things the batch settled. No track image means rows: is unavailable and a positive text: is mandatory, since a crash hands the browser an empty document where every noText: passes. Most hgTrackUi bugs ARE the markup, so naming the id or class the commit changed is the right check here, unlike on hgTracks. A cart round trip is the only way to tell a control that works from one that looks right. And Docent cannot pick an option from a select, so a visibility goes in through the URL and a button is clicked wherever one exists. Two candidates were rejected: #38192's missing-track message is live but the ticket is still Reviewing, and #37840's "add db= to links" is not true of every link on the page today, so a blanket assertion would fail for a reason that is not a bug. diff --git src/hg/utils/docent/tests/regress/rm37743.docent.yaml src/hg/utils/docent/tests/regress/rm37743.docent.yaml new file mode 100644 index 00000000000..603a3f48913 --- /dev/null +++ src/hg/utils/docent/tests/regress/rm37743.docent.yaml @@ -0,0 +1,36 @@ +# #37743 -- hgTrackUi took a SIGSEGV on a request for a duplicated track that was not in +# the cart. A bot tripped it during the v499 release, which is the part worth keeping in +# mind: the URL needs no login and no session, so anything that crawls a browser page can +# reach it. +# +# The duplicate-track feature names a copy dup__ and keeps the list in the cart. +# hgTrackUi split that name, found the source track's trackDb entry, then looked the copy +# up in the cart with dupTrackFindInList(); with no cart entry that returned NULL and the +# NULL went straight into dupTdbFrom(). 7b74ff4b43a adds two lines: if the lookup comes +# back empty, errAbort with a message that says which name it was. +# +# So the fixed behavior is an error page, and that is what this asserts. The name has to +# be shaped like a real duplicate -- dup_refGene alone never reaches the lookup, it fails +# earlier with "Can't find dup_refGene in track database hg38", which is a different path +# and passes on the crashing build too. dup_1_refGene is the shape the feature writes. +# +# hgTrackUi has no track image, so the positive text: is what tells a crash from a page: +# a SIGSEGV gives the browser an empty document, where every noText: check passes. +proof: + - "assertion-only 2026-09-12 -- written from the ticket and from 7b74ff4b43a, after the fix shipped" + +target: genome-test +db: hg38 +position: chr1:11102837-11267747 +reset: true +fast: true +steps: + - goto: "/cgi-bin/hgTrackUi?db=hg38&g=dup_1_refGene" + - expect: + text: "Can't find duplicate track dup_1_refGene" + url: "hgTrackUi" + + # The other path, named so the two stay told apart: a dup_ name with nothing after the + # prefix never reaches the cart lookup at all. + - goto: "/cgi-bin/hgTrackUi?db=hg38&g=dup_refGene" + - expect: {text: "Can't find dup_refGene in track database hg38"}