7eb4d115091bd389d5296d9198dbf0f327b35bdd braney Thu Sep 10 07:10:50 2026 -0700 docent: promote rm38310 out of .xfail, the #38310 fix reached genome-test 68f831e1209 landed on master 2026-09-09 and genome-test built it overnight, so the 2026-09-10 nightly went red the way an xfail is supposed to: the script that was expected to fail passed. Drop the .xfail from the name and rewrite the header paragraph that said the fix was not on master yet. This script has now been watched failing on genome-test and passing on the next build of that same server, which is stronger evidence than the sandbox A/B it already carried. refs #38310, refs #38252 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> diff --git src/hg/utils/docent/tests/regress/rm38310.xfail.docent.yaml src/hg/utils/docent/tests/regress/rm38310.docent.yaml similarity index 91% rename from src/hg/utils/docent/tests/regress/rm38310.xfail.docent.yaml rename to src/hg/utils/docent/tests/regress/rm38310.docent.yaml index 1dca577217f..8fb328a6d6b 100644 --- src/hg/utils/docent/tests/regress/rm38310.xfail.docent.yaml +++ src/hg/utils/docent/tests/regress/rm38310.docent.yaml @@ -1,22 +1,23 @@ -# #38310 -- EXPECTED TO FAIL until the fix ships. A hub track whose `type bigBed N` -# declares more fields than the file holds drew its row with no items in it. +# #38310 -- a hub track whose `type bigBed N` declares more fields than the file holds +# drew its row with no items in it. # -# The fix is written and verified but is NOT on master yet, so there is no server in the -# world that passes this today. It is an xfail rather than a test for that reason alone: -# `make test` fails if an xfail PASSES, so the day the fix reaches genome-test the suite -# says there is a test waiting. When it flips, drop the .xfail from the name. +# This was an xfail until 2026-09-10. The fix, 68f831e1209, reached master on 2026-09-09 +# and genome-test built it overnight. The nightly then went red because the xfail passed, +# and the .xfail came off the name. So this script was watched failing on a real server +# and passing on the next build of that same server. That is what makes it a regression +# test and not an assertion written after the fact. # # WHAT WENT WRONG, and why the ticket's own words are not quite right. #38310 says the row # came up empty "with no warning". The row is empty, but there IS a message: hgTracks # catches the abort into networkErrMsg (hg/hgTracks/hgTracks.c) and swaps in # bigDrawWarning, which paints the row as a pale yellow bar with the text in it. The text # read `invalid signed integer: ""` -- the fourth field of a four-field row array, which # was never filled in. So the message was there and said nothing useful, and it is drawn # INSIDE the png, which is why it is invisible to every text check in this suite and why # the original measurement (counting item map boxes in the HTML) reported silence. # # THAT IS WHY THE ASSERTION IS A COLOR CHECK. `color:` is the only check that reads the # image, and this is the second bug in this directory that needs it. Each row is asked for # the color it is actually drawn in: # # fixed white background (not counted) plus a black item box and a black pack label