4697bbddd881c72cccb85b9ff0aacd769396b9d0 braney Thu Sep 10 07:34:35 2026 -0700 docent: record what evidence each regression test has, and count it A regression test written after the fix asserts the right answer, but nobody has watched it fail for the reason it exists, and a loose assertion in that state is indistinguishable from no test at all. Four of the 37 scripts here have actually been watched to flip. That was recorded only as prose in each script's header, so answering "how many of these are real regression tests" meant a grep and a read, and the number could not be quoted. Every script now carries a top-level `proof:` key, one quoted line per piece of evidence, `<level> <YYYY-MM-DD> -- <what was seen>`. docent.js reads only the keys it names off the parsed document, so this costs a run nothing. tests/proof.js reads them and tallies, wired up as `make proof` in the shared docentTest.mk. It exits 1 on a malformed line, an unknown level, or a line left unquoted -- that last one because nearly every note names a ticket and a bare # in an unquoted YAML scalar silently truncates the sentence at the ticket number, which is how the first pass of this change lost half its text. The levels, weakest first: assertion-only, xfail, sandbox-ab, server-flip, caught-regression. Today that reads 31 / 2 / 0 / 3 / 1. nightly.sh now records the flips it finds. An xfail that PASSES is the best evidence this suite produces -- the same server, the same fixtures, the same script, one real build apart -- and until now it arrived as a red mail and was thrown away with the log 60 days later. It is appended to /hive/users/braney/docentNightly/flips.log, one line per script ever, outside the checkout because --update resets the tree. The mail says what to do with it. The three flips that already happened (rm38272 2026-09-06, rm36212 2026-09-09, rm38310 2026-09-10) were recovered from the old logs and seeded there by hand. Full suite run after the change: 37 scripts, all ok. refs #38252 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> diff --git src/hg/utils/docent/tests/regress/rm36061.docent.yaml src/hg/utils/docent/tests/regress/rm36061.docent.yaml index 51a945fa18f..8b83cb9a3c9 100644 --- src/hg/utils/docent/tests/regress/rm36061.docent.yaml +++ src/hg/utils/docent/tests/regress/rm36061.docent.yaml @@ -1,46 +1,49 @@ # #36061 -- the DECIPHER SNVs details page came up missing its details after a quickLift. # # Gerardo's steps from the ticket: hg38, hide all, DECIPHER to show, QuickLift to hs1, and # click the 517898 item in the DECIPHER SNV track. The lifted details page came back # without the fields the native one shows. # # The ticket's position, chr7:156,982,676-156,996,015, is the window every quickLift ticket # quotes, and item 517898 is not in it: it is at chr7:155,803,191-155,803,192, and # decipherSnvs draws nothing at all in the ticket's window. Following the ticket literally # gave "item 517898 not found ... 8 map box(es) in that row, addressable as: mergedItem, # ... 314209" -- those belong to decipherSnvs' sibling. So the window here is the one that # actually holds the item the ticket names. # # Two names are in play and only one of them is a row. decipherSnvs and decipher are # DIFFERENT tracks (SNVs and CNVs) under decipherContainer, which is a superTrack -- so it # does not pass its setting down, and its other members come up at their own trackDb # visibility however much the hide: all hid. The row to assert is decipherSnvs; `decipher` # turning up instead of it is the sign that the SNVs track drew nothing. +proof: + - "assertion-only 2026-09-05 -- written from the ticket after the fix had shipped" + target: genome-test db: hg38 position: chr7:155800000-155806000 reset: true fast: true steps: - go: chr7:155800000-155806000 - hide: all - track: {decipherContainer: show, decipherSnvs: pack} - expect: {rows: [decipherSnvs], noText: "Warning/Error"} - convert: {to: hs1, quicklift: true} - open: lift - expect: {rows: [decipherSnvs], noText: "Warning/Error"} - click: {track: decipherSnvs, item: "517898"} # The details themselves, not just the item's name -- "missing details" was the whole # report, and the name alone is on the page even when every field below it is gone. # These five are what the native hgc page prints for patient 517898, read off it rather # than guessed. - expect: text: "Ref Allele: A" noText: "Warning/Error" - expect: {text: "Alt Allele: G"} - expect: {text: "Transcript: ENST00000297261"} - expect: {text: "Genotype: Heterozygous"} - expect: {text: "Inheritance: Paternally inherited"}