7aba31f14aed7f2620e4746b54f9569a5c93e1ad braney Sat Sep 12 15:07:34 2026 -0700 docent: ten regression tests for quickLift, on hgTracks and on hgc, refs #38252 Fourteen scripts here already lift something -- they are the ones that call `convert: {quicklift: true}` -- so these take the parts of the lift that had no test. Five read the lifted image and five read a details page: rm38032 the target keeps the source's track order. First use of `ordered:`, which was added to expect: for this bug rm38042 a ClinVar CNV running past the chains quickLift loads is clipped rather than dropped, so the spanned-item merge still has it rm37646 a lolly composite subtrack lifts, and its map boxes still carry its own track name -- the string the stale pop pointer clobbered rm36048 the spanned-item merge still works on a lifted DECIPHER track rm37815 "Hide all default tracks on the target" hides all six of hs1's own tracks and keeps the lifted one rm36059 a lifted GENCODE Versions item gives the real details page, in destination coordinates, with no "Can't start query" rm36370 a lifted knownGene click renders GeneReviews and Methods, the two sections the ticket says were missing rm36125 a lifted RefSeq item's page, and its Predicted Protein link returning SHH's peptide instead of a blank page rm36942 the Alignment Differences description, reached from a difference item: the four colors and the figure rm38146 the same page with a GenArk assembly as the SOURCE, down to the base alignment that reads query bases out of a two bit file All ten are assertion-only: every fix shipped long ago. make test is 57 of 57 green in 10m18s, up from 7m34s -- each script costs a convert, about 17 seconds, because no URL builds a quickLift hub. README.txt gains what the batch cost. A lifted row and map box carry a per-run hub__ prefix, so rows: matches by suffix and a has: selector must use a substring. Never assert a count an otto reload can move: rm38042 and rm36048 both read the merged-item box and leave its count (45 for ClinVar today) to a comment. And a details page prints the track's own labels whether or not it worked, so each hgc assertion names something only the fixed page has. Three candidates were rejected: #38033's "(N items could not be lifted)" label is only in the drawn image and the page JSON, where no expect: check reaches it; #37970 needs a broadPeak track and hg38 has none; #37974's center-label drag is pixels. diff --git src/hg/utils/docent/tests/regress/rm37646.docent.yaml src/hg/utils/docent/tests/regress/rm37646.docent.yaml new file mode 100644 index 00000000000..2d4edadcce6 --- /dev/null +++ src/hg/utils/docent/tests/regress/rm37646.docent.yaml @@ -0,0 +1,49 @@ +# #37646 -- hgTracks aborted with +# +# Can't find tdb for subtrack ... was getSubtrackTdb called on non-subtrack? +# +# when a quickLift hub carried a lolly composite subtrack. Found while reviewing #37536. +# +# The abort was not where the bug was. 3fe4305d047: in lollyLoadItems, when +# quickLiftIntervalsToBed() returned NULL for an item that did not lift, the loop fell +# through and reused a stale pop pointer, writing item fields into whatever memory it +# pointed at. That clobbered the subtrack's own trackDb strings -- track, shortLabel, +# type -- and the abort came later, when something asked for the subtrack by a name that +# was no longer there. +# +# So the tight thing to assert is the field that got clobbered, not only that the page +# came back: every map box hgTracks writes for this row carries g=, and that +# name is the string the stale write destroyed. `rows:` alone would not do it, since a +# row is drawn under either name. +# +# clinvarSubLolly (ClinVar interp, type bigLolly) is a subtrack of the clinvar composite, +# which is the shape the ticket names. Whether an item in this particular window fails to +# lift -- the trigger for the stale pointer -- was not established, so treat this as an +# assertion about the page the ticket could not produce rather than a reproduction of the +# corruption. +proof: + - "assertion-only 2026-09-12 -- written from the ticket and from 3fe4305d047, after the fix shipped" + +target: genome-test +db: hg38 +position: chr7:155799529-155812871 +reset: true +fast: true +steps: + - go: chr7:155799529-155812871 + - hide: all + - track: {clinvar: pack, clinvarMain: hide, clinvarCnv: hide, clinvarSubLolly: pack} + - expect: + rows: [ruler, clinvarSubLolly] + exact: true + has: 'area[href*="g=clinvarSubLolly"]' + + - convert: {to: hs1, quicklift: true, hideDefaults: true} + - open: lift + + # The abort left no image at all, so the row list is the positive half and the ticket's + # own string is the negative one. The map-box check is the clobbered field. + - expect: + rows: [clinvarSubLolly] + noText: "Can't find tdb for subtrack" + has: 'area[href*="clinvarSubLolly"]'