d033cea2063e9362949baf5b4d8b837597173a0d max Thu Sep 10 05:16:05 2026 -0700 Address the code review of the Sep 9 commits Faceted composite: text that comes from a hub - a metadata column's description, the name and title of a data type, and the values quoted back in the "could not load the metadata" row - is put on the page as text rather than as markup. The three places built their markup from template strings, so a value carrying angle brackets or a quote was read as HTML: the column description now goes through the shared htmlEncode() once where the header is parsed, and the other two build their elements as nodes. The error row reads better for it as well, since a value with brackets in it used to disappear from the message that was meant to show it. The saved UI state keys on the assembly as well as the metadata id. localStorage is per-origin, so two assemblies whose tracks share a name were sharing one entry, and a row order dragged on one came back on the other over a different set of samples. hgTrackUi passes the database down for it. State saved under the old key is dropped, which costs a facet selection or a page length. Imprinting: the five subtrack description pages link back to the container as hgTrackUi?db=$db&g=$parentTrack, without the hgsid. Native trackDb html is substituted by hgTrackDb as it loads the table, where there is no cart, so ${hgsid} came out empty and the link read 'hgsid=&g=...'. Matches what the Fiber-seq pages already do. The makeDoc note that described the old form is updated with the reason. UniProt otto: README.txt lists all eight things that reach runLog.txt. It had four, and was missing LOCKED, along with PREFLIGHT-FAIL, END and INTERRUPTED. refs #36210 refs #37599 refs #38300 diff --git src/hg/makeDb/doc/hg38/kaplanImprint.txt src/hg/makeDb/doc/hg38/kaplanImprint.txt index b498517aa23..692d3cbc857 100644 --- src/hg/makeDb/doc/hg38/kaplanImprint.txt +++ src/hg/makeDb/doc/hg38/kaplanImprint.txt @@ -158,19 +158,21 @@ # 7. Publish ############################################################################## # trackDb: composite kaplanImprint added to human/hg38/imprinting.ra, under the # existing Imprinting collection. The subtracks share one description page, # kaplanImprint.html. # # The kaplanAsm subtrack, the bimodal regions whose methylation follows a # heterozygous SNP, is built by the scripts above but its trackDb stanza is # commented out: those regions are driven by the DNA sequence rather than by # imprinting, so they do not belong in this collection. The bigBed and the # /gbdb symlink are in place, so uncommenting the stanza is all it takes to # bring the track back. # # The description pages of the subtracks open with a link back to the container, -# written as hgTrackUi?db=$db&hgsid=${hgsid}&g=$parentTrack so that the same -# markup works in a hub. Both $parentTrack and a working $hgsid need an hgTrackDb -# built after Sep 2026; an older /cluster/bin/x86_64/hgTrackDb stops the trackDb -# load with 'setting "parentTrack" not found', and resolves $hgsid to nothing. +# written as hgTrackUi?db=$db&g=$parentTrack. No hgsid: native trackDb html is +# substituted by hgTrackDb when it loads the table, where there is no cart, so +# ${hgsid} would resolve to the empty string and the link would come out as +# 'hgsid=&g=...'. $parentTrack needs an hgTrackDb built after Sep 2026; an older +# /cluster/bin/x86_64/hgTrackDb stops the trackDb load with 'setting +# "parentTrack" not found'.