d033cea2063e9362949baf5b4d8b837597173a0d
max
Thu Sep 10 05:16:05 2026 -0700
Address the code review of the Sep 9 commits
Faceted composite: text that comes from a hub - a metadata column's
description, the name and title of a data type, and the values quoted back in
the "could not load the metadata" row - is put on the page as text rather than
as markup. The three places built their markup from template strings, so a
value carrying angle brackets or a quote was read as HTML: the column
description now goes through the shared htmlEncode() once where the header is
parsed, and the other two build their elements as nodes. The error row reads
better for it as well, since a value with brackets in it used to disappear from
the message that was meant to show it.
The saved UI state keys on the assembly as well as the metadata id. localStorage
is per-origin, so two assemblies whose tracks share a name were sharing one
entry, and a row order dragged on one came back on the other over a different
set of samples. hgTrackUi passes the database down for it. State saved under the
old key is dropped, which costs a facet selection or a page length.
Imprinting: the five subtrack description pages link back to the container as
hgTrackUi?db=$db&g=$parentTrack, without the hgsid. Native trackDb html is
substituted by hgTrackDb as it loads the table, where there is no cart, so
${hgsid} came out empty and the link read 'hgsid=&g=...'. Matches what the
Fiber-seq pages already do. The makeDoc note that described the old form is
updated with the reason.
UniProt otto: README.txt lists all eight things that reach runLog.txt. It had
four, and was missing LOCKED, along with PREFLIGHT-FAIL, END and INTERRUPTED.
refs #36210
refs #37599
refs #38300
diff --git src/hg/makeDb/trackDb/human/hg38/geneimprint.html src/hg/makeDb/trackDb/human/hg38/geneimprint.html
index fc7a1399f79..233930d5e27 100644
--- src/hg/makeDb/trackDb/human/hg38/geneimprint.html
+++ src/hg/makeDb/trackDb/human/hg38/geneimprint.html
@@ -1,19 +1,19 @@
<h2>Description</h2>
<p>
-Part of the <a href="hgTrackUi?db=$db&hgsid=${hgsid}&g=$parentTrack">Imprinting</a> track collection, this track shows the human part of the Geneimprint
+Part of the <a href="hgTrackUi?db=$db&g=$parentTrack">Imprinting</a> track collection, this track shows the human part of the Geneimprint
catalog, with each gene placed on the genome. The catalog itself gives only a cytogenetic band, so the
coordinates here come from resolving the gene symbols against the
<a href="hgTrackUi?g=hgnc">HGNC</a> gene annotation. Note that the track
contains all of the catalog, including 18 genes that Geneimprint records as
<em>not</em> imprinted and 10 whose status is unknown. Use the filters on the
track configuration page to narrow the display to the evidence levels you want.
</p>
<h2>Display Conventions and Configuration</h2>
<p>
Each item is one gene from the catalog, drawn over the span of the resolved
locus. The item is labeled with the name Geneimprint uses, which for older
entries can differ from today's approved symbol; the configuration page can
switch the label to the approved symbol instead. Clicking an item opens a page