fcb6dc8dfa166136193177c895ca181200850e4d max Mon Jan 19 06:02:31 2026 -0800 changing superTrack TrackUi quite a bit. Removing dropdowns and replacing them with buttons. Also adding buttons for setting all tracks or all visible tracks to a visibility. While at it, making a change to the js-query-library function (inversed the order of arguments) which was requested months ago by Brian, but I forgot to make the change after code review. Also shortening the "source data version" label to just "version". refs #36917. I changed the library function hTvDropDownClassVisOnlyAndExtra() rather than copying the code. This was because I was hesitant to copy/paste all this code into a second function, which would have been the only alternative, as the function cannot be reused as-is. So I modified the function to return the list of visibilities. It's never clear whether it's better to modify functions or copy/paste code. here, not breaking the function into smaller parts, so copy/pasting it, would risk requiring more future copy/pasted code. But the risk is to break existing tracks. diff --git src/inc/cheapcgi.h src/inc/cheapcgi.h index c5b0ab6f18c..52bfce69f7f 100644 --- src/inc/cheapcgi.h +++ src/inc/cheapcgi.h @@ -17,31 +17,31 @@ //============ javascript inline-separation routines =============== void jsInlineFinish(); /* finish outputting accumulated inline javascript */ void jsInline(char *javascript); /* Add text to output file or memory structure */ void jsInlineF(char *format, ...) /* Add javascript text to output file or memory structure */ #if defined(__GNUC__) __attribute__((format(printf, 1, 2))) #endif ; -void jsOnEventBySelector(char *query, char *eventName, char *jsText); +void jsOnEventBySelector(char *eventName, char *query, char *jsText); /* Add js mapping for inline event given a query selector, e.g. '.className' */ void jsAddEventForId(char *eventName, char *idText, char *jsText); /* Add js mapping for inline event, adding multiple events as needed */ void jsOnEventById(char *event, char *idText, char *jsText); /* Add js mapping for inline event */ void jsOnEventByIdF(char *event, char *idText, char *format, ...) /* Add js mapping for inline event with printf formatting */ #if defined(__GNUC__) __attribute__((format(printf, 3, 4))) #endif ;